Repository navigation
FlatpakBackend: Fix xml handling with newer libxml - #2447
Merged
Merged
Conversation
danirabbit
reviewed
Oct 1, 2026
danirabbit
approved these changes
Oct 1, 2026
danirabbit
left a comment
Member
There was a problem hiding this comment.
Would love a comment, but this works! Nice fix :)
Co-authored-by: Danielle Foré <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer libxml requires explicitly passing the option
XML_PARSE_UNZIPif decompression is required: https://gitlab.gnome.org/GNOME/libxml2/-/commit/063add1b298450637fd7a0fbd2f515b10e71d00dXML_PARSE_UNZIPisn't available in the vapi though so just pass the raw value. We have to switch to manually decompressing anyways sometimes in the future because libxml plans to remove built in compression support entirely.Fixes #2445