Skip to content

ci: set cache-mode on release workflows - #408

Merged
MarshallOfSound merged 1 commit into
mainfrom
ci/cache-mode
Oct 22, 2026
Merged

MarshallOfSound merged 1 commit into
mainfrom
ci/cache-mode

Conversation

@claude

@claude claude Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Requested by David Sanders · Slack thread

Before: The Release workflow (push to main) and the Publish documentation workflow (version tag push) could read from and write to the GitHub Actions cache. Today they avoid it only by convention: each actions/setup-node step opts out with package-manager-cache: false, but nothing stops a future step, action, or the reusable test.yml that release.yml calls from restoring a cache entry into a release run.

After: Both workflows declare cache-mode: none at the top level. During a release or docs-publish run, every job is denied cache access by the runner, regardless of per-step settings. Because release.yml invokes test.yml via uses:, the none setting also caps the test jobs when they run as part of a release (PR CI runs of test.yml are unaffected and keep caching). Any step that still tries to restore or save a cache logs a message and continues rather than failing (a skipped restore is a cache miss; a skipped save is a no-op). The existing package-manager-cache: false lines are left in place.

Why: GitHub added a workflow- and job-level cache-mode key so release paths can be fenced off from the shared Actions cache; see the changelog post and the workflow syntax reference.

How: Adds a top-level cache-mode: none (with a one-line comment) after the permissions: block in .github/workflows/release.yml and .github/workflows/docs.yml. No other lines change; test.yml and the other PR-CI workflows are untouched.

Note that PR CI does not exercise the release or docs workflows, so the first release (and first tag push) after merge is the real test. A denied cache step logs and continues rather than failing the run.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MYe3WCXtgiqomNuVQdi4Yd


Generated by Claude Code

Add top-level `cache-mode: none` to release.yml and docs.yml so the
release and docs-publish paths never read from or write to the Actions
cache, regardless of per-step settings.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
Claude-Session: https://claude.ai/code/session_01MYe3WCXtgiqomNuVQdi4Yd
@dsanders11
dsanders11 marked this pull request as ready for review October 22, 2026 21:40
@dsanders11
dsanders11 requested a review from a team as a code owner October 22, 2026 21:40

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) October 22, 2026 21:45
@MarshallOfSound
MarshallOfSound merged commit f5c67ee into main Oct 22, 2026
11 checks passed
@MarshallOfSound
MarshallOfSound deleted the ci/cache-mode branch October 22, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants