Repository navigation
ci: add required-ci gate job - #69
claude[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01Rx13DJRnFBvVNh1ioMMXsQ
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. Because this workflow file is owned by the electron/wg-infra team per CODEOWNERS, a human look from that team is still worthwhile before merging.
What was reviewed:
- The new
required-cijob:needs: test,if: always(), and the failure condition usingcontains(needs.*.result, 'failure'/'cancelled')— correctly aggregates the matrixtestjob's overall result (fail-fast rollup), matching the described electron/forge pattern. - Confirmed the job has no side effects beyond an echo/exit, and doesn't alter
test's existing matrix, permissions, or triggers. - No secrets, credentials, or new permissions are introduced;
permissions: contents: readat the workflow level is unchanged.
Extended reasoning...
The change adds a single required-ci aggregator job to .github/workflows/test.yml that depends on the existing matrix test job and fails if it failed or was cancelled, a standard branch-protection pattern with no security-sensitive surface (no secrets, new permissions, or code execution changes). The logic checks out: needs.*.result on a matrix job reflects its overall rollup status. The only reason for defer rather than approve is that this workflow path falls under a blanket CODEOWNERS rule (electron/wg-infra owns the whole repo), so a human from that team should still weigh in per review policy.
Requested by Samuel Attard · Slack thread
This adds a single
required-cijob to the Test workflow (test.yml). It depends ontestand fails if it failed or was cancelled, so branch protection can require one stable check name. This matches electron/forge. Branch protection or the ruleset needs updating separately to require it.🤖 Generated with Claude Code
https://claude.ai/code/session_01Rx13DJRnFBvVNh1ioMMXsQ
Generated by Claude Code