Skip to content

ci: add required-ci gate job - #69

Open
claude[bot] wants to merge 1 commit into
mainfrom
ci/required-ci-gate
Open

claude[bot] wants to merge 1 commit into
mainfrom
ci/required-ci-gate

Conversation

@claude

@claude claude Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Requested by Samuel Attard · Slack thread

This adds a single required-ci job to the Test workflow (test.yml). It depends on test and fails if it failed or was cancelled, so branch protection can require one stable check name. This matches electron/forge. Branch protection or the ruleset needs updating separately to require it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Rx13DJRnFBvVNh1ioMMXsQ


Generated by Claude Code

@claude
claude Bot requested a review from a team as a code owner September 27, 2026 07:17

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. Because this workflow file is owned by the electron/wg-infra team per CODEOWNERS, a human look from that team is still worthwhile before merging.

What was reviewed:

  • The new required-ci job: needs: test, if: always(), and the failure condition using contains(needs.*.result, 'failure'/'cancelled') — correctly aggregates the matrix test job's overall result (fail-fast rollup), matching the described electron/forge pattern.
  • Confirmed the job has no side effects beyond an echo/exit, and doesn't alter test's existing matrix, permissions, or triggers.
  • No secrets, credentials, or new permissions are introduced; permissions: contents: read at the workflow level is unchanged.
Extended reasoning...

The change adds a single required-ci aggregator job to .github/workflows/test.yml that depends on the existing matrix test job and fails if it failed or was cancelled, a standard branch-protection pattern with no security-sensitive surface (no secrets, new permissions, or code execution changes). The logic checks out: needs.*.result on a matrix job reflects its overall rollup status. The only reason for defer rather than approve is that this workflow path falls under a blanket CODEOWNERS rule (electron/wg-infra owns the whole repo), so a human from that team should still weigh in per review policy.

@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) October 6, 2026 16:47

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants