Skip to content

Skip renovate updates for internal cross-module imports - #7693

Merged
swiatekm merged 1 commit into
mainfrom
swiatekm/Renovate-don-t-update-internal-references
Aug 27, 2026
Merged

Skip renovate updates for internal cross-module imports#7693
swiatekm merged 1 commit into
mainfrom
swiatekm/Renovate-don-t-update-internal-references

Conversation

@swiatekm

@swiatekm swiatekm commented Aug 26, 2026

Copy link
Copy Markdown
Member

Prevent renovate from updating internal cross-module imports of the root fleet-server module. See #7659 for an example.

Copilot AI lite review requested due to automatic review settings August 26, 2026 19:14
@swiatekm
swiatekm requested a review from a team as a code owner August 26, 2026 19:14
@swiatekm
swiatekm requested review from lorienhu and samuelvl August 26, 2026 19:14
@mergify

mergify Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

This pull request does not have a backport label. Could you fix it @swiatekm? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@swiatekm swiatekm added backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team ci CI related tasks skip-changelog labels Aug 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository Renovate configuration to stop Renovate from opening dependency update PRs for internal cross-module Go module references within the Fleet Server repo (e.g., github.com/elastic/fleet-server/pkg/api, github.com/elastic/fleet-server/v7), preventing noisy/incorrect self-update proposals like the example in PR #7659.

Changes:

  • Adds a gomod package rule that disables Renovate updates for module paths under github.com/elastic/fleet-server/....

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread renovate.json
Comment thread renovate.json
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

TL;DR

The failing Buildkite run is an E2E test failure in TestStandAloneRunningSuite/TestAgentGracefulForceUnenroll, and it is very unlikely to be caused by this PR because this PR only changes renovate.json. Immediate action: rerun the E2E job; if it fails again, collect full test output for that subtest to pinpoint which timeout gate is tripping.

Remediation

  • Re-run .buildkite/scripts/e2e_test.sh for this PR to rule out transient test instability.
  • If it reproduces, inspect the failing stage in testing/e2e/stand_alone_test.go at L862-L940 (the three Eventually(...) gates for online state, empty policy application, and UNENROLL log emission) and capture the full subtest assertion output (current log excerpt does not include it).
Investigation details

Root Cause

The build failed in E2E with a single failing subtest:

  • TestStandAloneRunningSuite/TestAgentGracefulForceUnenroll (222.17s)

This PR modifies only renovate.json (10-line config change) and no Go/runtime/test code, so there is no direct code path from PR changes to this E2E runtime behavior.

The failing subtest logic in testing/e2e/stand_alone_test.go (L862-L940) relies on time-bounded asynchronous conditions (Eventually) around agent check-in and unenroll sequencing. The observed runtime is consistent with a timeout-style test failure, but the provided Buildkite log segment does not contain the specific assertion line needed to identify which of the three gates timed out.

Evidence

  • Build: https://buildkite.com/elastic/fleet-server/builds/16476

  • Job/step: E2E Test (.buildkite/scripts/e2e_test.sh)

  • Key log excerpt:

    • --- FAIL: TestStandAloneRunningSuite/TestAgentGracefulForceUnenroll (222.17s)
    • FAIL github.com/elastic/fleet-server/testing/e2e
  • PR diff scope:

    • renovate.json only (Skip renovate updates for internal cross-module imports)
  • Relevant test code:

    • testing/e2e/stand_alone_test.go:L862-L885 (wait for online/updating)
    • testing/e2e/stand_alone_test.go:L902-L924 (wait for empty policy / no running components)
    • testing/e2e/stand_alone_test.go:L933-L940 (wait for UNENROLL log emission)

Verification

  • Not run locally in this workflow (read-only detective analysis).

Follow-up


What is this? | From workflow: PR Buildkite Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@swiatekm
swiatekm enabled auto-merge (squash) August 27, 2026 11:10
@swiatekm
swiatekm merged commit 52f718c into main Aug 27, 2026
18 checks passed
@swiatekm
swiatekm deleted the swiatekm/Renovate-don-t-update-internal-references branch August 27, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip notification from the automated backport with mergify ci CI related tasks skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants