Repository navigation
Conversation
ejams1
added this pull request to stack #106
October 20, 2026 22:39
Owner
Author
|
Superseded by the phase-7 branch: the system-font change is in phase-7-gui's Cargo.toml (eframe with default-features = false and the system_fonts feature), and the portable scratch path is in 79ab3a5. |
ejams1
removed this pull request from stack #106
October 22, 2026 05:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable eframe's bundled default font feature and keep the GUI's explicit system font provider enabled. The GUI no longer bundles the default font assets. The selection-dialog integration test now creates scratch data under the platform temporary directory instead of a developer-specific drive path, so it works on CI runners.
Validation
cargo check -p xedit-guiwas run in the GUI worktreecargo test -p xedit-gui --test selection_dialogs(4 passed)cargo deny check licensescould not fetch missing registry metadata because this environment lacks registry credentials