Skip to content

Support useJdkVersion flag and test JDK matrix via Gradle toolchains - #171

Merged
wmdietl merged 1 commit into
mainfrom
use-jdk-version
Sep 19, 2026
Merged

wmdietl merged 1 commit into
mainfrom
use-jdk-version

Conversation

@wmdietl

@wmdietl wmdietl commented Sep 19, 2026

Copy link
Copy Markdown
Member

Matches Checker Framework's convention for specifying the target JDK version using -PuseJdkVersion.

  • Adds majorVersionToInt to parse -PuseJdkVersion, configuring the Java toolchain accordingly.
  • Falls back to sourceCompatibility = 1.9 and targetCompatibility = 1.9 when -PuseJdkVersion is omitted.
  • In CI (workflow.yml), passes -PuseJdkVersion=${{ matrix.jdk }} to ./gradlew build so matrix entries actually compile and test with their respective JDK versions under Gradle's Java toolchain while the Gradle daemon runs on JDK 21.
  • Uses mkdir -p ~/.gradle in CI to avoid errors if the directory already exists.
  • Replaces the for (int i = start; i < end; i++) loop in the test listener with (start..<end).each { i -> ... } to avoid the greclipse formatting bug that caused i <end.

Copilot AI lite review requested due to automatic review settings September 19, 2026 01:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@wmdietl
wmdietl merged commit 08e9226 into main Sep 19, 2026
6 checks passed
@wmdietl
wmdietl deleted the use-jdk-version branch September 19, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants