Repository navigation
Add the file and parser packages to the add-opens compiler arguments - #17
Merged
Merged
Conversation
…uments The new javac-based parser in the Checker Framework uses classes from com.sun.tools.javac.file and com.sun.tools.javac.parser. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01GW8C4XvQcY7RQkVAqStDB6
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused configuration change is consistent with existing javac access settings and addresses the reported failure.
Review effort: Balanced
Findings: None
What changed in this PR
Adds the required javac package access for Checker Framework compatibility.
Changes:
- Opens
javac.fileandjavac.parseron JDK 9+.
| File | Description |
|---|---|
guava/pom.xml |
Adds the missing compiler module access arguments. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Checker Framework now parses Java expressions with javac's parser, which needs access to the
com.sun.tools.javac.fileandcom.sun.tools.javac.parserpackages.guava/pom.xmlopens the other compiler packages but not these two, so the Checker Framework run on guava failed with anIllegalAccessErrorforJavacFileManager. The top-level and android POMs already list them.This pairs with the Checker Framework pull request that merges the 3.50.0 release into EISOP and uses the same branch name,
typetools-3.50.0-merge, so CI picks it up automatically. It is harmless on its own, so it can be merged before that pull request.🤖 Generated with Claude Code