Repository navigation
typetools/checker-framework 3.53.0 release - #2198
Merged
Merged
Conversation
Co-authored-by: Michael Ernst <[email protected]> Co-authored-by: Suzanne Millstein <[email protected]> Co-authored-by: Manu Sridharan <[email protected]> Co-authored-by: Daniel Gao <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…contain The import of typetools/checker-framework 3.50.0 did not contain 31 of the commits of 3.49.5..3.50.0. Cherry-pick them, as one commit. The changes that this repository needs are: * the typo fixes in the release README, * the additions to .gitignore (the union of this repository's entries and typetools' new ones), * removing the dependency of every Test task on allDataflowTests in dataflow/build.gradle, as in typetools (nonJunitTests and allTests still run it). The other 28 commits have no effect here: they are dependency and plugin updates where this repository's version is newer, typetools' JDK selection scheme, the move of the Compiler Messages check to all projects, the Shadow plugin update, the Maven Central URLs, ruff and mypy installation, and fixes that this repository's reworked scripts already contain. Of the "Fixes to the release scripts", the hunk that comments out ensure_group_access(DEV_SITE_DIR) is not taken; it works around a problem on typetools' server. Co-authored-by: Michael Ernst <[email protected]> Co-authored-by: Suzanne Millstein <[email protected]> Co-authored-by: Damika-Anupama <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Adopt typetools' "Use version catalog" with this repository's versions: the versions of the plugins and libraries are in gradle/libs.versions.toml, and the build files refer to them as libs.* and libs.plugins.*. This replaces the library versions in gradle.properties that were adopted from typetools' earlier commit. The catalog uses typetools' names where typetools has an entry, with google-guava for the unannotated Guava, because typetools' guava is the annotated one. The resolved dependencies of every subproject and the versions of the plugins do not change. Co-authored-by: Suzanne Millstein <[email protected]> Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
typetools replaced markdownlint by pymarkdownlnt and removed .markdownlint-cli2.yaml. This repository's Makefile still has the markdownlint-fix and markdownlint-check targets, which read that file, so restore it as it was. Whether to switch to pymarkdownlnt, and to enable the check in style-check, is for a later change. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
wmdietl
force-pushed
the
typetools-3.53.0-fixes
branch
from
October 2, 2026 04:40
e889845 to
3b11fae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the typetools Checker Framework 3.53.0 release into
master. The import itself was reviewed and merged in #2197. Please merge this pull request with a merge commit, with the subjecttypetools/checker-framework 3.53.0 release (#2198)and an empty body, so that the typetools commits keep their authorship.The 31 commits of 3.50.0 that the import of 3.50.0 (#2186) did not contain
I computed these by comparing the commits of 3.49.5..3.50.0 with the commits of #2186. They are in one commit here, because this pull request is merged without squashing: its message has the authors as
Co-authored-bylines and says what has an effect. 28 of the 31 change nothing; the three with changes are below.useJdkVersionscheme), "Run Compiler Messages Checker" (ours defines the check inframeworkandchecker, the only modules withmessages.properties), "Use new location for releasing to Maven central" (ours already uses the new URLs), "Don't try to install ruff or mypy" (our CI image has no ruff), "Remove extra repositories block", "Add comment to top-level Makefile", "Fix formal parameter type", the two release stamps ("Prep for next release", "new release 3.50.0"), and the two commits that were already present..gitignorefile" (the union of our entries and typetools' new ones), and "Don't addallDataflowTestsas adependsOnto all test tasks". The last one means:dataflow:testno longer runsallDataflowTests;nonJunitTestsandallTestsstill do, as in typetools.ensure_group_access(DEV_SITE_DIR), which works around a problem on typetools' own server.Other changes
gradle/libs.versions.toml, and the build files refer to them aslibs.*. This replaces the library versions ingradle.propertiesthat were adopted from typetools' earlier commit. The names follow typetools' catalog;guavais the annotated Guava as in typetools, and the unannotated one isgoogle-guava. The resolved dependencies of every subproject (334 lines, checked before and after) and the versions of all plugins do not change..markdownlint-cli2.yamlis restored; typetools removed it when it moved topymarkdownlnt, and our Makefile still has the targets that read it.Still open
uv(typetools' Makefile runs ruff andtythroughuvx, which our CI image does not have).markdownlint-checkcan joinstyle-check, and thepython-typechecktarget.eisop/jdkpull requests Merge stores after expression statements #158 (README,master, JDK 17) and Store paths for artificial trees #159 (jdk-21: typetools/jdk up to 3.53.0 andmaster).Tested:
tasks --all,compileJava,compileTestJava,assembleForJavac, azip/copyToWebsitedry run, and the full:dataflow:test,:dataflow:allDataflowTests,:framework:testand:checker:testsuites pass on JDK 21;spotlessCheck,ruff,requireJavadocandjavadocDoclintAll(on changed lines) are clean. CI covers the rest.🤖 Generated with Claude Code