Skip to content

Adds conversion to bytearray within Segment #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eerimoq merged 1 commit into from
Feb 24, 2026
Merged

Adds conversion to bytearray within Segment #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bincopy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ class Segment:
def __init__(self, minimum_address, maximum_address, data, word_size_bytes):
self.minimum_address = minimum_address
self.maximum_address = maximum_address
self.data = data
self.data = bytearray(data)
self.word_size_bytes = word_size_bytes

@property
Expand Down
9 changes: 9 additions & 0 deletions tests/test_bincopy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1810,6 +1810,15 @@ def test_add_elf_keil(self):
with open('tests/files/elf/keil.bin', 'rb') as fin:
self.assertEqual(bf.as_binary(), fin.read())

def test_add_elf_modify_overwrite(self):
bf = bincopy.BinFile()
bf.add_elf_file('tests/files/elf.out')

data = b'test'
address = bf.minimum_address
bf.add_binary(data, address=address, overwrite=True)
self.assertEqual(data, bf.as_binary(minimum_address=address, maximum_address=address+len(data)))

def test_exclude_edge_cases(self):
binfile = bincopy.BinFile()
binfile.add_binary(b'1234', address=10)
Expand Down