Skip to content

tp container fixes and fore update - #262

Open
duncdrum wants to merge 3 commits into
mainfrom
fix-249
Open

duncdrum wants to merge 3 commits into
mainfrom
fix-249

Conversation

@duncdrum

Copy link
Copy Markdown
Contributor

fix tp publisher docker workflow

be consistent in declaring fore

bump for to 2.9.0 throughout

- Added new file sets for JavaScript and CSS resources from the @jinntec/fore package in build.xml.
- Modified HTML files to use the updated resource paths for the fore library.
- Updated various profile configurations to use the new version of the fore library.
@duncdrum duncdrum changed the title Fix 249 tp container fixes and fore update Feb 2, 2026
@DrRataplan

Copy link
Copy Markdown
Contributor

Depending which merges first (#201 or this one), the dependency from annotations to forms needs to change. The #201 PR introduces a profile for fore, so the version management is centralized.

@JoernT JoernT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR looks good to me

Comment thread package.json
},
"homepage": "https://github.com/eeditiones/jinks#readme",
"dependencies": {
"@jinntec/fore": "^2.9.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should maybe already go for 3.0.1

@tuurma

tuurma commented Apr 21, 2026

Copy link
Copy Markdown
Member

@duncdrum As @DrRataplan mentioned, now that #201 is merged, something needs to change. Please also go already for fore 3.0.1 as @JoernT suggested. Conflicts need resolving, blah, blah...

Also please remove fore stuff from base.html (both regular and static), this is now done through config and form blocks.

@tuurma tuurma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes requested in the comment

@tuurma
tuurma marked this pull request as draft April 21, 2026 14:43
@duncdrum
duncdrum marked this pull request as ready for review April 27, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants