Skip to content

docs: use NET-LINE for EU Hydro examples and drop it from the tree - #78

Merged
mckeea merged 1 commit into
developfrom
docs/filenaming-euhydro
Sep 8, 2026
Merged

docs: use NET-LINE for EU Hydro examples and drop it from the tree#78
mckeea merged 1 commit into
developfrom
docs/filenaming-euhydro

Conversation

@MatMatt

@MatMatt MatMatt commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Updates to the CLMS filenaming guidelines:

  • Rename the EU Hydro example filenames to the NET-LINE form (dropping the descriptive _S2026_R10m_ tokens) in the design-principles doc
  • Remove the EU Hydro (EUHYDRO) branch from the filename tree so EGMS L2 is the terminal node
  • Fix alignment spacing on the SWF (HRL - 5m) line

validate_qmd_files.py: 36/36 valid.

- Rename the EU Hydro example filenames to the NET-LINE form (dropping the
  descriptive _S2026_R10m_ tokens) in the design-principles doc
- Remove the EU Hydro (EUHYDRO) branch from the filename tree so EGMS L2 is
  the terminal node
- Fix alignment spacing on the SWF (HRL - 5m) line

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 411950dcb9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

├── L2a-A, L2a-D, L2b-A, L2b-D EGMS calibrated (EGMS L2)
└── NET, DIR, SUB EU Hydro (EUHYDRO)
└── L2a-A, L2a-D, L2b-A, L2b-D EGMS calibrated (EGMS L2)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the remaining EU Hydro product-code branch

Removing this variable branch does not fully drop EU Hydro from the filename tree: the By Product Code section at lines 49–50 still advertises EUHYDRO-NET_S{YYYY}_R10m_EUROPE_3035_V02-R00.gpkg. Readers therefore still see the obsolete pattern that this commit replaces with NET-LINE; remove or update that earlier branch as well.

Useful? React with 👍 / 👎.

**Rule:** Omit production date from filenames. Include it only when multiple production runs for the same temporal period coexist in the same distribution channel. When present: `{YYYYMMDD}` as the last token before the extension.

**Compliant:** `CLMS_EUHYDRO-NET_S2026_R10m_EUROPE_3035_V02-R00_20261015.gpkg`
**Compliant:** `CLMS_EUHYDRO-NET-LINE_EUROPE_3035_V02-R00_20261015.gpkg`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Document the omitted temporal field

For new EU Hydro deliveries, this is now labeled a compliant full filename even though it omits the temporal field required by the canonical template and token-count invariant in Principle 5, while Principle 8 defines no timeless/optional temporal case. Because dropping _S2026_ is intentional, add an explicit atemporal exception and reflect it in the filename tree/schema; otherwise implementers following this document cannot determine whether EUROPE is an extent or a shifted temporal token.

Useful? React with 👍 / 👎.

@mckeea
mckeea merged commit 716cef0 into develop Sep 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants