Skip to content

docs: correct product descriptions in CLMS filenaming guidelines - #77

Merged
mckeea merged 2 commits into
developfrom
docs/filenaming-product-descriptions
Sep 8, 2026
Merged

docs: correct product descriptions in CLMS filenaming guidelines#77
mckeea merged 2 commits into
developfrom
docs/filenaming-product-descriptions

Conversation

@MatMatt

@MatMatt MatMatt commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Apply Lorenzo's feedback to the CLMS filenaming guidelines:

  • Attribute the IW burst field to the Sentinel-1 swath, not EGMS InSAR (both design-principles and filename-tree)
  • Rephrase the EGMS L3 grid and L2 orbit descriptions to their official labels

validate_qmd_files.py: 36/36 valid.

Apply Lorenzo's feedback:
- Attribute IW burst to Sentinel-1 swath, not EGMS InSAR
- Rephrase EGMS L3 grid and L2 orbit descriptions with their official labels

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7b58417d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

├── L3-U, L3-EW EGMS velocity components (EGMS Ortho – L3)
├── L2a-A, L2a-D, L2b-A, L2b-D EGMS calibrated (EGMS L2)
├── L2a-A, L2a-D, L2b-A, L2b-D Orbit (EGMS Calibrated – L2)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Label L2a as Basic rather than Calibrated

Because this branch includes both L2a-A/D and L2b-A/D, describing the entire group as “EGMS Calibrated” misidentifies the L2a variants. The repository's EGMS product description identifies L2a as Basic (DOCS/European_Ground_Motion_Service/Product_Description_v3.qmd:51-61) and L2b as Calibrated (:63-67, :446-448); split the labels or name both product levels here.

Useful? React with 👍 / 👎.

@mckeea mckeea self-assigned this Sep 8, 2026
@mckeea
mckeea self-requested a review September 8, 2026 12:35
@mckeea
mckeea merged commit 5177b73 into develop Sep 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants