Skip to content

Fix overlong line [GH #421] - #450

Merged
daveedvdv-nvidia merged 1 commit into
mainfrom
fix/449
Oct 31, 2026
Merged

daveedvdv-nvidia merged 1 commit into
mainfrom
fix/449

Conversation

@daveedvdv-nvidia

@daveedvdv-nvidia daveedvdv-nvidia commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

My original change to fix GH #421 somehow slipped through with an overlong line.

This should fix that.

Summary by CodeRabbit

  • Style
    • Reformatted an internal expression; behavior is unchanged.

@daveedvdv-nvidia
daveedvdv-nvidia requested a review from a team October 30, 2026 23:16
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 5984bca and 070848f.

Files selected for processing: 1
  • src/interpret.c

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Walkthrough

The compute_interpreter_base_offset call used to adjust this_val->address was reformatted across multiple lines. Its expression and behavior are unchanged.

Changes: Interpreter address calculation

Layer / File(s) Summary
Reformat address adjustment call
src/interpret.c
The compute_interpreter_base_offset call was split across multiple lines. The calculation is unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other · Severity of issue fixed: Low

Possibly related issues

  • edgcpp/compiler issue 449: Reports the overlong line that this change re-wraps.

Possibly related PRs

  • edgcpp/compiler#425: Implements the virtual-overrider behavior whose call is reformatted here.

Suggested reviewers: nv-cmeerw

Merge Risk: Minimal · up to 07084

This formatting-only change introduces no identified merge risk.

Architecture risk: Low · up to 07084

The change affects 1 system.

Changed systems: src

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in src/interpret.c: Reformatted the compute_interpreter_base_offset call used to adjust this_val->address; the calculation is unchanged.
Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately and concisely describes the main change: reformatting an overlong line related to GH #421.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@edgcpp-bot

Copy link
Copy Markdown
Collaborator

AcknowlEDG review results updated for 070848f01620:

CI success.

@codecov

codecov Bot commented Oct 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@daveedvdv-nvidia
daveedvdv-nvidia added this pull request to the merge queue Oct 31, 2026
Merged via the queue into main with commit 95112a4 Oct 31, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants