Repository navigation
Conversation
daveedvdv-nvidia
left a comment
daveedvdv-nvidia
left a comment
Contributor
There was a problem hiding this comment.
A question about whether this is desired in Clang C++ mode in addition to GNU C++ mode.
Contributor
|
I'll merge after the CI checks have completed (even though this is just wording changes). |
Contributor
|
A last-minute agentic review found some minor issues... I'll let it devise a patch. |
Contributor
|
@mborland : Can you review the commit I added to the PR? |
Collaborator
|
AcknowlEDG review results updated for
CI success. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GCC when using C++ you are allowed to combine
inlineandno inlinewithout warning, which is a common idiom in Boost. In plain C mode GCC warns. This PR changes to match the GCC behavior or not warning in C++ mode, as previously it warned in both.Closes: #183