개선(deps): Bump adm-zip and @huggingface/transformers - #154
Merged
Merged
Conversation
Bumps [adm-zip](https://github.com/cthackers/adm-zip) to 0.6.1 and updates ancestor dependency [@huggingface/transformers](https://github.com/huggingface/transformers.js). These dependencies need to be updated together. Updates `adm-zip` from 0.6.0 to 0.6.1 - [Release notes](https://github.com/cthackers/adm-zip/releases) - [Changelog](https://github.com/cthackers/adm-zip/blob/master/history.md) - [Commits](cthackers/adm-zip@v0.6.0...v0.6.1) Updates `@huggingface/transformers` from 4.2.0 to 4.3.0 - [Release notes](https://github.com/huggingface/transformers.js/releases) - [Commits](huggingface/transformers.js@4.2.0...4.3.0) --- updated-dependencies: - dependency-name: adm-zip dependency-version: 0.6.1 dependency-type: indirect - dependency-name: "@huggingface/transformers" dependency-version: 4.3.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Contributor
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
eddmpython
added a commit
that referenced
this pull request
Sep 22, 2026
증상 - Dependabot 경보가 머지 뒤에도 열려 있었다. 루트 lock: sharp 0.35.3(#68 high, libheif), adm-zip 0.6.0(#75 high 메모리 할당, #61 medium 심볼릭 링크 추출). pushHub lock: sharp 0.35.3(#69 high). - #154(transformers 4.3.0 + adm-zip 0.6.1 을 표방)와 #155(sharp 0.35.4)를 머지했는데도 master 의 lock 은 adm-zip 0.6.0, sharp 0.35.3 이었다. 원인 - 루트 package.json 의 overrides 가 sharp 와 adm-zip 을 정확 버전으로 고정한다. Dependabot 은 override 를 올리지 못하므로 #154 는 transformers 만 올렸다(adm-zip 은 override 0.6.0 에 묶임). - #155 는 rebase 뒤 override 값만 0.35.4 로 바꾸고 lock 은 0.35.3 그대로였다. transformers 4.3.0 이 sharp ^0.35.4 를 요구하는데도 npm ci 가 이 불일치를 거부하지 않아 Deploy Landing 은 통과했고, 실제 설치는 취약 버전이었다. - infra/workers/pushHub/package.json 도 자체 override 로 sharp 0.35.3 을 고정한다. 변경 - package.json overrides: adm-zip 0.6.0 -> 0.6.1 (sharp 는 #155 가 이미 0.35.4). - infra/workers/pushHub/package.json overrides: sharp 0.35.3 -> 0.35.4. - 두 lock 은 npm install --package-lock-only 뒤 npm update sharp adm-zip --package-lock-only 로 재생성했다. override 값만 바꾸면 npm 이 이미 잠긴 항목을 다시 해석하지 않아 update 가 필요했다. - 버전 변화는 sharp·@img/sharp-*·@img/sharp-libvips-*(0.35.4/1.3.3), @emnapi/runtime 1.11.3, adm-zip 0.6.1 뿐이다. 루트 lock 의 나머지 텍스트 차이는 #148 lock 에 빠져 있던 "dev": true 표기를 npm 이 정규화한 것이다. 검증 (origin/master c717a4c 기준 별도 worktree) - 루트 npm ci 성공, 설치 버전 sharp 0.35.4 / adm-zip 0.6.1 / vitest 5.0.1. - landing check 통과, landing test 22 파일 186 개 통과, landing build 성공. - @dartlab/ui-runtime test 17 파일 105 개 통과. - pushHub npm ci 성공, 설치 sharp 0.35.4, test 2 파일 24 개 통과. 남은 것 - vitest 계열 경보(#62 #64 #65 #66)는 #148(vitest 5) 머지로 lock 상 해소됐다. 경보는 GitHub 재스캔 뒤 닫힌다. - Dependabot 이 override 대상 취약점을 스스로 닫지 못하는 구조는 그대로다. 다음 경보도 같은 절차(override 수동 상향, lock 재생성, npm ci 확인)가 필요하다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps adm-zip to 0.6.1 and updates ancestor dependency @huggingface/transformers. These dependencies need to be updated together.
Updates
adm-zipfrom 0.6.0 to 0.6.1Release notes
Sourced from adm-zip's releases.
Commits
cb2cf9bFixed addLocalFolderAsync2 mangling local paths on Windows54902b6Fixed addLocalFolderPromise hanging on empty folders and swallowing errors73131bdFixed CI758898dRejected zip entries whose declared data extent runs past the buffer74b6e9fRouted malformed-header parse errors through the async callbackeaa35faBlocked extraction from writing through symlinks inside the target1e015e3Increment version05101d4Rejected archives with duplicate entry names4916006Enforced the decompression size cap on the async path and for size 06a63c33Stripped setuid/setgid/sticky bits from extracted file permissionsUpdates
@huggingface/transformersfrom 4.2.0 to 4.3.0Release notes
Sourced from @huggingface/transformers's releases.
... (truncated)
Commits
a1728dd[version] Update to 4.3.0f9dec42Bump dependencies (#1766)dce094eMassive documentation overhaul (#1665)37fddf9Fix RawAudio.toBlob() ignoring TypedArray byteOffset/length (#1712)eb5d05eSkip browser cache writes for non-http(s) resources (#1723)3991b6aCreate@huggingface/transformers-structured-outputpackage (#1758)6fe1cccPin WebGPU KV cache for ImageAudioTextToText models (Gemma3n, Gemma4) (#1757)f09d000Correctly dispose Chatterbox KV cache after generation (#1737)3152877Remove unused code and exports (#1763)274446cFix Moonshine ASR token decoding (#1738)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.