Repository navigation
UX improvements to roster search (EDFIAL-689) - #195
Merged
Merged
Conversation
in testing, a reviewer clicked search straight away with the form still pre-filled from the file. idrs had already searched those values for the suggestions, so nothing new could come back, and each search is slow. search is now disabled, with a short hint, while the form holds the file's values or the search whose results are shown. spacing, id order and repeated ids don't count as changes. the directions point reviewers to their sis first, and each field they change is tagged as edited. an invalid date of birth blocks the search with a format hint, shown once the reviewer leaves the field or presses enter, instead of the search route's raw validator message. while a search runs the button reads "searching…", and an error hides the earlier results. some files repeat an id across columns, so ids now show once in the form, the header and the suggestions, and are sent once. the copy now says "the file" rather than "your file": reviewers load vendors' files and don't think of them as their own. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
edandylytics
changed the title
|
✅ I finished the code review, and didn't find any security or code quality issues. |
in the four-column form it was cut off at "any IDs, e.g. state or lo". the label already says student ids, so "any IDs" repeated it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
a highlighted border made an edited field look like the active one. the "edited" tag beside the label is enough. Co-Authored-By: Claude Opus 5.5 <[email protected]>
shown under the field, it made every input in the row taller. it now sits below the field in the gap above the search button. Co-Authored-By: Claude Opus 5.5 <[email protected]>
an error hides the results, so after a failed search, editing back to the search already shown left search disabled with nothing to show for it. an error is about the search that failed, so editing clears it. also split the bad-date test so its name says what it shows: a bad date in the file's own values is reported ahead of those values. Co-Authored-By: Claude Opus 5.5 <[email protected]>
it passed the same bad-date terms as both the form and the file, so it only showed that a bad date is a bad date, which the test above already covers. it now contrasts an unedited form with a good date, blocked as the file's values, with the same form carrying the file's bad date, blocked as a bad date. that pins the order of the two checks: swapping them fails this test alone. the test above is renamed to say its bad date is typed. Co-Authored-By: Claude Opus 5.5 <[email protected]>
edandylytics
requested review from
rtavernaea
and
a balanced review from Copilot
and removed request for
Copilot
November 4, 2026 17:39
rtavernaea
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves a handful of small UX things on the roster search, addressing EDFIAL-689.
Previously, it wasn't clear that (a) the values defaulted into the search form came from the file, (b) you had to edit those values in order to actually get a match, or (c) how to know what values to use. Now we tell users to find the student in the SIS and edit the form to match what they see there. The search button is only enabled once the form is edited (and there's a hint telling the user to update the form to enable the button)
There are a handful of other change included:
Use YYYY-MM-DDinstead of the regex1234, 1234, 1234in the ID field. This is change also dedups IDs elsewhere, when the ID value + type are the same.Search button disabled, with hint
"edited" flag and date validation
