Repository navigation
raise the idrs search timeout to 45 s - #189
Merged
Merged
Conversation
some reviewer searches in prod take into the high 20s, past the 20 s timeout, so they fail with identity_service_unavailable. 45 s gives about 1.6x headroom over the slowest searches seen so far. it stops short of 60 s because the alb idle timeout and nginx's proxy_read_timeout both cut the request at 60 s, and getting credentials can take up to 10 s before the search starts. at 45 s our own 502 always reaches the client instead of a bare 504. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
rtavernaea
approved these changes
Nov 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the timeout for IDRS queries initiated from the app. Previously, it was 20 seconds. Now, it's 45 seconds. We'd noticed that some queries for larger districts would take in the mid-20 sec to run and were hitting the timeout. It looks like we have a 60 second overall timeout on the request form the user's browser (the ALB default), so 45 sec on the query allows us to also accommodate slow token requests. In any case, it looks like 45 sec should be enough headroom given the limited data we've got right now.
The Executor does not have a timeout, so doesn't need to make a similar change.