Repository navigation
Type image-effects' heading and use US spellings, so the site's checks pass - #41
Merged
Merged
Conversation
The site's astro check refused ImageEffects.astro:831: `h${headingLevel}`
is a string there, so <Heading> took no attributes. Cast it to the tags
headingLevel allows, the way Tabs, Accordion and FlipBox already do.
The elements merged on 10-30 put UK spellings on five site pages
(centred, colour, grey, organisation, forced colours). The site's
check:us-english reads built pages, so the library's own check never saw
them. Fixed in catalog.ts, the photo-gallery demo's alt text, and the
headers of call-to-action, logo-grid and image-effects. Identifiers and
CSS custom properties are unchanged.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library's half of unblocking superherotech.ai. The site's half, which is what actually lets Pages build again, is ecropolis/SuperheroTech#95.
Library main fails two of the site's checks. The library's own check doesn't run either of them, so it never saw the failures:
ImageEffects.astro:831,const Heading = \h${headingLevel}`is a plain string under the site's tsconfig, sowon't type. It now gets the same cast as Tabs, Accordion and FlipBox (as 'h1' | 'h2' | 'h3', the levelsheadingLevel` allows).catalog.ts, the photo-gallery demo's alt text, and the headers of call-to-action, logo-grid and image-effects. Identifiers and CSS custom properties are unchanged.Proof.
npm run checkexits 0 here. The site's fullnpm run checkchain exits 0 with this branch asELEMENTS_SOURCE, together with SuperheroTech#95: astro check shows 0 errors and 0 warnings, and check:elements, check:us-english and check:datalayer all pass. The site'sdemo-heights.jsonrecords this commit (3a3d958) as the one it was measured against.Merge order. Either order works. Merging this fires the Pages deploy hook. Until SuperheroTech#95 is on main, that build fails exactly as it does today (103 > 100
_headersrules), so merging this first changes nothing live.#40 touches different lines of
catalog.ts, so the two shouldn't conflict.🤖 Generated with Claude Code