perf: split useProofSubmit into usePendingProofs and useProofSubmit - #76
Open
Timothy2025-20 wants to merge 1 commit into
Open
perf: split useProofSubmit into usePendingProofs and useProofSubmit#76Timothy2025-20 wants to merge 1 commit into
Timothy2025-20 wants to merge 1 commit into
Conversation
- Create usePendingProofs for HomeScreen (lightweight, only queue count and sync) - Keep useProofSubmit for SubmitProofScreen (full submission flow) - Both hooks share the same proofQueue module - No behavioral change - proof submission, queuing, and sync work identically - Add tests for both hooks independently - HomeScreen renders fewer state updates when proof state changes Closes ecotask-network#56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh pr create
--title "perf: split useProofSubmit into usePendingProofs and useProofSubmit"
--body "## Description
This PR splits the useProofSubmit hook to avoid unnecessary state allocations on HomeScreen.
Changes
Acceptance Criteria Met
Closes #56