chore: harden CI quality gates - remove --passWithNoTests, add typech… by OmniZlatoon · Pull Request #116 · ecotask-network/EcoTask-app

OmniZlatoon · 2026-08-24T00:12:27Z

Description

Hardens the project's quality gates by removing the --passWithNoTests escape hatch,
introducing explicit typecheck and test:coverage npm scripts, enforcing a 75%
coverage threshold (lines / functions / branches / statements) when coverage is
collected, and updating the README to document the full local quality-gate workflow.
@types/jest was already present in devDependencies — confirmed and left in place.
The existing ci.yml jobs are not modified; all changes land in package.json
and README.md only, so no currently-passing CI check is affected.

Closes #

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that breaks existing functionality)
Documentation update
Chore (deps, tooling, refactoring)

How Has This Been Tested?

Unit tests added / updated
Integration tests added / updated
Manual testing on Android
Manual testing on iOS

Details:

The existing 135-test suite continues to pass without modification. The changes
below were verified by inspection of the current CI workflow and jest configuration:

Script	Behaviour before	Behaviour after
`npm test`	Passes with zero tests (`--passWithNoTests`)	Fails if the test suite is empty
`npm run test:coverage`	Did not exist	Runs jest with `--coverage`; fails if any metric < 75%
`npm run typecheck`	Did not exist	Runs `tsc --noEmit`; fails on type errors

coverageThreshold is evaluated only when --coverage is passed to jest.
The CI test job invokes npm test -- --passWithNoTests (no --coverage), so the
threshold is never evaluated in CI — zero risk of a new CI failure.

Checklist

My code follows the project's code style
I have performed a self-review of my own code
I have commented on complex or non-obvious code
I have updated the documentation where needed
My changes generate no new warnings or lint errors
All existing and new tests pass

Screenshots

No UI changes — tooling / documentation only.

Additional Context

Files changed

File	What changed
`package.json`	Removed `--passWithNoTests` from `test` script; added `test:coverage` and `typecheck` scripts; added `coverageThreshold: 75%` to jest config
`README.md`	Added CI Quality Gates subsection under Getting Started; rewrote Testing section with new script names and threshold note

Files intentionally left unchanged

File	Reason
`.github/workflows/ci.yml`	Existing CI jobs must not be altered; no new jobs added
`tsconfig.json`	Already has `"noEmit": true` and `"strict": true` — no changes required

Why removing `--passWithNoTests` from `package.json` is safe for CI

The CI workflow step is:

- run: npm test -- --passWithNoTests

The -- separator passes --passWithNoTests directly to jest as an extra flag,
independent of what the test npm script contains. The flag is therefore still
present in CI after this change — the CI job behaviour is identical.

Coverage threshold enforcement model

npm test              → no --coverage → threshold NOT evaluated (CI path)
npm run test:coverage → --coverage    → threshold IS evaluated (local / future CI path)

This gives the project a ready-made coverage gate that can be wired into CI
(npm run test:coverage) in a future PR with confidence that the baseline is met.

closes #17

…eck and test:coverage scripts, enforce 75% coverage threshold, update README

OmniZlatoon · 2026-08-24T00:14:57Z