document lack of end layers fitting #373 - #386
Open
rozyczko wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #386 +/- ##
============================================
+ Coverage 0.00% 42.44% +42.44%
============================================
Files 42 48 +6
Lines 3573 3824 +251
============================================
+ Hits 0 1623 +1623
+ Misses 3573 2201 -1372
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gradient discretization now always includes both endpoints (front and back materials), using
linspacefor even spacing and eliminating off-by-one errors.The minimum allowed number of discretization elements is now enforced as 2 (front and back), with improved error messages
The
GradientLayerclass and its documentation now make it explicit that the front and back materials are frozen at construction and are excluded from the parameter tree, preventing them from being offered as fittable parameters. This avoids silent no-ops if a user tries to fit them.