Repository navigation
Fix favicon appearance updates for 0.2.2 - #51
Merged
Merged
Conversation
Observe main-document icon and media changes after loading, and select matching light/dark icons. Keep appearance variants separate in memory and on disk, refresh restored artwork on app appearance changes, and reject obsolete discovery results. Include the 0.2.2 release highlights. Validation: 17 focused favicon tests and 8 release-note tests pass. Regression controls fail with media filtering, mutation handling, and appearance cache separation removed, then pass with the fixes restored. SwiftPM and direct Swift compiler Debug/Release builds pass. The fresh 0.2.2 Debug app passes strict/deep code-signature verification. Standard Xcode builds remain blocked during package resolution by the agent's nested-sandbox restriction. WebKit integration fixtures compile but cannot load pages with the native services unavailable in this session; they still require a normal Terminal or CI run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Website icons could keep the wrong light/dark variant until reload because discovery ran only once after loading. Observe later icon and media changes, select matching variants, and cache light/dark artwork separately. Includes the 0.2.2 release notes.
Validation: 17 focused favicon tests and 8 release-note tests pass; negative controls confirm the regressions are caught. SwiftPM and direct compiler Debug/Release builds pass, and the fresh Debug app passes signature verification. Standard Xcode builds and live WebKit integration remain blocked by this agent session’s sandbox and need CI verification.