Skip to content

Fail closed on incomplete review context - #2

Merged
dymoo merged 1 commit into
mainfrom
fix/fail-closed-review-coverage
Jul 29, 2026
Merged

Fail closed on incomplete review context#2
dymoo merged 1 commit into
mainfrom
fix/fail-closed-review-coverage

Conversation

@dymoo

@dymoo dymoo commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Outcome

  • fails instead of emitting reviewed=true when a non-ignored file is binary, has no textual hunk, or exceeds the file cap
  • fails when rendering truncates a hunk above the 30k-token request budget
  • fails when the 120k-token aggregate budget drops any rendered block
  • preserves intentional ignore behavior, including ignored binary paths
  • keeps ignored-only paths visible in the sticky audit summary

Why

A required review gate cannot report success after silently omitting changed material. Consumers can now treat reviewed=true as complete coverage evidence for every non-ignored textual change.

Validation

  • npm run format
  • npm run check-all — 96/96 tests
  • real-entrypoint tests prove both token failure modes exit nonzero, make zero model calls, and emit no outputs
  • independent adversarial review: no blockers

@dymoo
dymoo merged commit 3d1a1bf into main Jul 29, 2026
2 of 3 checks passed
@dymoo
dymoo deleted the fix/fail-closed-review-coverage branch July 29, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant