Skip to content

Preserve timer deadlines across MariaDB status updates #1139

Closed

Description

@rmcdaniel

MariaDB 10.5's default explicit_defaults_for_timestamp=OFF gives the first non-null TIMESTAMP column an implicit ON UPDATE CURRENT_TIMESTAMP(6). The published timer migration leaves workflow_run_timers.fire_at subject to that behavior. Cancelling or firing a timer can therefore replace its scheduled deadline with the database wall clock.

The complete MariaDB feature gate for #1132 exposed three existing occurrence-deadline regressions: false-wake reopen, signal resolution, and reopening an already-past anchor. The first two completed shards pass; the third is retained as NONPASS. A separate disposable MariaDB 10.5.29 SQL control reproduces the status-only deadline change. An explicit timestamp default removes the automatic update and preserves nonzero microseconds through the same update.

Implement a forward migration for the affected MariaDB column, honoring the configured storage connection and schema lock budget. Preserve all stored values and existing timer identities. Do not change the historical migration or mask the defect with a fixture server setting. Recover an occurrence's first deadline from its immutable scheduled history when an older mutable timer row has already drifted; refuse an unavailable anchor rather than inventing a backfill.

Acceptance:

  • Fresh and upgraded MariaDB schemas preserve a timer's exact deadline through cancellation and firing. Repeating the migration is safe; other backends retain their schema and behavior.
  • Existing occurrence history remains authoritative after a drifted cancelled timer row. No fresh allowance, timer firing, or historical rewrite is introduced.
  • Existing rollback/conflict controls and the complete MariaDB feature inventory pass, including all three observed regressions.
  • Normal style, static analysis, unit, coverage, feature, source review and accepted-main gates remain required. This is an embedded storage correction, with no retired PHP Server release or package qualification inferred.

Related: #1066, #1063. MariaDB's documented behavior: https://mariadb.com/docs/server/reference/data-types/date-and-time-data-types/timestamp

Activity

  1. rmcdaniel commented on Nov 14, 2026

    @rmcdaniel
    MemberAuthor

    Delivered by #1140 at accepted main 42bcc5d28f45b1ebbe94fa77662bb190e0d051ba. The guarded forward MariaDB migrations preserve stored deadlines and reject unexpected legacy metadata; occurrence reopen uses its immutable history anchor. All three reported regressions, migration/refusal controls, the complete default-MariaDB inventory and normal quality gates passed. Final evidence and accepted-main verification retain the earlier failures and independent source review. The source correction is complete; published-package qualification remains separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent:workflowkind:defectA public product behavior is incorrectpriority:P1High-priority product or release risk

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions