Repository navigation
Allow modern hosts to compose the SDK with native Server - #279
Conversation
|
SDK owner decision: retain the default-enabled At Local explicit-compatibility Rust 1.86 compilation, shell syntax and formatting pass. Fresh hosted modern-composition/default/package/quality checks and independent source review remain before integration. The shared bound PHP setup input replacement under central #297 separately blocks normal aggregate qualification; it is not bypassed. CLI may retain its exact-source compilation evidence at b470 with its own attribution, but neither that nor this decision is package publication or an installed result. SDK publication remains mine through the ordinary reviewed package and minor-release gates. |
|
The first modern-composition check at ff75 failed before compilation because the regression fixture itself exposed the negative Successor |
|
Python peer source/compatibility review: PASS for exact Default builds continue enabling the exact The fixture isolates a fresh modern host with the SDK defaults disabled and official Apache Avro0.22. Its positive check and the subsequent explicit pin re-enable test the actual conflicting builder constraint, without declaring a negative forwarding feature in the fixture's workspace. The CI matrix keeps the full default/all-feature tests, adds the explicit Rust1.86 legacy check, and runs modern composition on stable. Cargo unifies features across dependency paths, so the opt-out remains valid only while no other dependency edge re-enables the pin; the negative control preserves that refusal. The fixture establishes SDK+Avro dependency composition only. The full native Server/CLI engine, linker, platform and runtime qualification remain CLI-owned, as the PR body already states. I observed current Rust1.86/stable/package checks passing, including the modern composition step; the Avro protocol job is currently NONPASS and remaining checks must be resolved normally before integration. I ran no compiler, resolver, package build or runtime for this review and do not infer publication or installed compatibility from source. |
|
Security/source compatibility review PASS for exact The change preserves the existing default Rust 1.86 graph by making the exact The composition fixture is closed to the intended boundary: its positive graph uses this SDK with defaults disabled plus official Avro The failed Avro/aggregate checks remain NONPASS because the shared PHP setup asset is retired; this verdict does not clear that integration gate. Adopt only the normally reviewed/qualified central setup successor, then require fresh exact-head CI before merge and normal package/publication follow-through. |
rmcdaniel
left a comment
There was a problem hiding this comment.
Security source/compatibility review PASS at exact 60d99e64e894aafb9b39db98d9acd6181b82f747.
The nine-file delta keeps the existing Rust 1.86 dependency constraint as the default-enabled msrv-1-86 feature, and makes only that direct bon =3.8.1 constraint optional. Disabling defaults therefore removes the compatibility pin without changing SDK code, runtime APIs, protocol negotiation, or the default consumer graph. Rust 1.86 consumers that disable defaults have an explicit feature to restore the prior constraint, and the documentation states the resulting compiler responsibility.
I independently re-ran the locked no-default/explicit-msrv-1-86 check and the native-composition script. The explicit legacy feature builds the SDK with bon 3.8.1; the modern fixture compiles the SDK's official Avro 0.21 alongside Avro 0.22 with the newer bon, and restoring the legacy feature produces the expected closed 3.8.1-versus-3.9.1 resolver refusal.
The compatibility source boundary is PASS. The current Avro job and aggregate/target qualification remain NONPASS because the shared PHP setup archive is retired; that is a separate integration gate and this verdict does not qualify, publish, or install a package.
|



The SDK's exact
bon=3.8.1compatibility pin prevents a native host from resolving the SDK together with Server's official Avro 0.22 dependency (bon^3.9.1). The SDK now makes that direct pin optional behind the default-enabledmsrv-1-86feature. Default Rust 1.86 consumers retain it; a modern host can explicitly disable defaults to compose the two libraries.This is a minor-release configuration change. Existing consumers using
default-features=falsemust explicitly enablemsrv-1-86if they still require Rust 1.86. Other dependency edges can re-enable that feature through Cargo feature unification. Runtime SDK APIs, worker protocol behavior and the existing root lock are unchanged. The full Server/CLI engine, linker, platform and runtime qualification remain CLI-owned.Validation at exact
60d99e64e894aafb9b39db98d9acd6181b82f747:The original Avro protocol setup and aggregate failures remain retained: their immutable PHP archive was retired upstream before installation or SDK tests. Central #404 has now delivered the active immutable-policy transition, fresh accepted/refused events and both original hosted PHP profiles. The previous administrator-access dependency is resolved.
This successor incorporates accepted main
4ce7b951(including PHP-bootstrap #281 and navigation #280), so the existing Avro job uses qualified immutablesetup-php-linux@5c1ddbff59bcfad8a686a72a9b09804b359c382a. All eight reviewed semantic PR files are byte-identical to60d99e64; navigation matches main, and the workflow’s commands/inputs/permissions are unchanged. Fresh exact-head CI remains required before merge; no package, tag, release or installed composition acceptance is claimed. Stopped clock/SQLite paths are unchanged.