Repository navigation
Reopen grouped condition waits with their authored timeout - #190
Conversation
The PHP Server accepts a grouped (parallel/select) condition reopen only when its timeout_seconds equals the original and latest opens (recordedGroupedConditionReopenMatches); #188's remaining-time reopen was refused with invalid_commands and stalled the run. Grouped reopens send the authored timeout again, as sdk-php does, while the history's latest open still carries it; ungrouped reopens keep the remaining time. Replay still accepts a reopen at or below the authored timeout. Fixes #189 Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
General interim review (Security unavailable), head Why it's held
Code verified in a bounded container (Rust 1.86.0): full suite 775/0, corpus 28/28.
Once the fixture is in and CI is green, this is CLEAR. I'll check the change set. |
Adds grouped-condition-false-wake-authored-timeout (parallel) and selected-condition-false-wake-authored-timeout (select, new corpus.selected-condition-timed-reopen workflow): a 30 s grouped wait woken 12 s later must reopen with 30, not 18. Both fail with main's remaining-time grouped reopen. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
|
General interim review (Security unavailable): cleared to merge at exact head f9362d6.
|



Fixes #189. This must land before the 4.11.2 freeze: main carries the regression from #188, which hasn't been released.
Problem
#188 (#187) made every condition reopen carry the time remaining since the first open, grouped waits included. On the PHP Server, Workflow's
DefaultWorkflowTaskBridge::recordedGroupedConditionReopenMatchesaccepts a grouped (parallel/select) reopen of a still-open wait only when itstimeout_secondsequals both the original and the latest open. OtherwiseparallelCommandsMatchSequencesfails the whole completion with409 invalid_commands, and the task stays leased. Live on published PHP Server 2.11.8 with main efc67b5: two timed grouped waits plus onevotegave a reopen batch ofvotes 288,approvals 300, which was refused, and the run stuck.Native 3.0.5 refuses parallel groups (
development_parallel_group_unqualified), so it isn't affected. Ungrouped reopens are accepted with the remaining time on both Servers.Change
ConditionWaitCall: when a grouped member reopens and the history's latest physical open still carries the authored timeout, it sends the authored timeout. That's the only value the PHP Server accepts, and it's what sdk-php Register each cold logging worker before polling #271 does.grouped-condition-timed-reopen-keeps-deadlinevalid.Tests
grouped_condition_reopen_sends_the_authored_timeout, for parallel and select: a grouped wait opened at 300 s, then a wake 12 s later, must reopen with300, with the same occurrence id. The counterfactual (main's behavior) gets288.condition-wait-false-wake-keeps-deadline(ungrouped, 18).Live check (PHP Server 2.11.8, bounded Compose stack on lab2, logging proxy, all removed afterwards)
The same repro, with a worker built from this branch: the false-wake completion was
votes 300,approvals 300, and the Server accepted it (seq 3 and 4 opened). That's the gate.Separate and pre-existing: on the following task, Rust's replay refuses the Server's history with
condition_wait_group_reopen_mismatch. The Server satisfied only one member (seq 2) but recorded a reopen for the other, unsatisfied one (seq 3 after an unresolved seq 1). Released 4.11.1 does exactly the same: same commands, same failure. So it isn't caused by #188 or this PR; it's filed separately as the two-member grouped follow-up.🤖 Generated with Claude Code