Skip to content

Prove published PHP multi-page iterators - #425

Merged
rmcdaniel merged 2 commits into
mainfrom
agent/sdk-php/247-installed-pagination
Nov 17, 2026
Merged

rmcdaniel merged 2 commits into
mainfrom
agent/sdk-php/247-installed-pagination

Conversation

@rmcdaniel

@rmcdaniel rmcdaniel commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

This adds the missing installed PHP pagination case for shared #247 using the existing published SDK 3.18.2 (f9483bb2) and immutable native 3.8 tuple. No SDK library API or release changes.

One ordinary Worker completes five uniquely typed targets and one foreign control. The installed list generator must return exactly the five filtered instances over three two-item pages. The exact-run history generator must fetch lazily and equal the bounded complete reference history, without gaps or duplicates. Actual client metrics count real page requests, and registry distribution/reflection/Composer identities bind the result. Main-only selectors reject candidates, foreign tuples and conflicting qualifications before execution; the sibling Laravel job remains disjoint.

The prior independent source/case review remains bound to 45e60d9. All three scenario/control file bodies are unchanged in a1f7b2a; it folds accepted main with the activated and hosted-qualified setup action 5c1ddbff. The earlier retired-asset prerequisite is resolved. Seventeen local selector controls pass; all current-head checks pass, including all five PHP profiles and ordinary installed-worker checks, and Sonar has no unresolved finding. General reviewed the combined source; that current review is not independent.

After normal integration and actual-main verification, run the one named registry pagination invocation and review its artifacts before publishing the PHP guide and closing the PHP slice of #247. No installed pagination invocation has occurred yet. Prior setup failures remain historical NONPASS; #419/#420 and other qualification flags are unchanged.

@rmcdaniel

Copy link
Copy Markdown
Member Author

Security review for exact 45e60d9d205b31b4328247cd9d0cd2346e4b5219: source/case PASS; exact caller HOLD on the shared setup dependency.

The pagination scope is closed correctly:

  • main-only workflow dispatch, published SDK 3.18.2 source/dist f9483bb2..., native 3.8.0 image 7988a235..., no candidate source and mutual exclusion from activity-identity/Laravel/other qualification flags;
  • six real completed workflows with a distinct foreign type, five exact filtered IDs over three two-item pages, lazy first-page request evidence and no prefix/filter substitution;
  • exact selected run identity, a bounded complete reference history, multi-page two-item iteration byte/structure-equal to that reference, and no gaps/duplicates/live worker;
  • installed registry distribution/reflection/Composer identity and result tuple are retained.

The four pagination selector controls and four activity-identity composition controls pass locally; current-head PHP/lint/quality suites are terminal success.

The exact workflow still invokes setup-php-linux@411a14ac..., whose bound Ubuntu 24/PHP 8.3 archive now returns HTTP 404. Therefore the old green PR run is not current caller evidence and no installed pagination dispatch should be selected from this head. Rebind only to the normally reviewed/activated central #404 successor, rerun the exact source/caller checks, then require current main integration before one runtime invocation.

No pagination runtime, installed-package qualification or broader tuple is cleared here.

@sonarqubecloud

Copy link
Copy Markdown

@rmcdaniel
rmcdaniel marked this pull request as ready for review November 17, 2026 06:39
@rmcdaniel
rmcdaniel merged commit 36a2eca into main Nov 17, 2026
38 checks passed
@rmcdaniel
rmcdaniel deleted the agent/sdk-php/247-installed-pagination branch November 17, 2026 06:52
@rmcdaniel

Copy link
Copy Markdown
Member Author

The installed PHP pagination case passed once on 44034403250/attempt 1, from accepted main 36a2ecad23b5eabd01f90dc738c6e9052928133c.

The actual consumer installed normal-registry SDK 3.18.2 at f9483bb2b5b45f591a82d9e5419c5b60a6e967c6 from its ZIP distribution, against native 3.8.0, immutable index 7988a23525d9e50e997a9f6f02e801300ed4f626de3cf6977033657ae7e9f58e. Reflection, installed Composer identity, lock source/dist and the actual native discovery agree. No source override or fallback was used.

Five exact completed target IDs were returned over three real two-item list pages; the sixth foreign-type workflow was excluded. The selected original run's three events over two two-item history pages equal its complete reference history. Construction and first-yield checks prove lazy fetching. All six workflows completed with their expected results, the Worker deregistered, and the unconditional Server-removal step succeeded. The original caller does not retain a separate post-removal inventory; none is claimed.

Artifact 14307305252 was downloaded and verified against sha256:49134cd8e6e3e2280cdb66a32bc3cf297e19f88de83db3275bd2f5dcb421ec6a. The existing PHP client guide is live with both generators, page sizes, lazy/early-stop behavior and the original namespace/run boundary. General reviewed the artifact and live guide; this is not an independent second-agent review. The prior exact source/case Security review remains scoped to 45e.

Normal main integration passed all five workflows. The original Laravel-13 setup HTTP403 remains retained; one failed-only source-CI retry passed without changing credentials, inputs or source. That was source CI, not a pagination rerun. The pagination invocation itself passed on attempt 1.

PHP's installed result and existing guide are delivered. Shared #247 remains open until its cross-binding evidence and core documentation parity table are reconciled. No new SDK release, other runtime tuple, #419/#420 or clock/helper acceptance follows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant