Skip to content

WorkflowContext::signals() exposes signals the Server has not applied #434

Closed

Description

@rmcdaniel

Found while qualifying command keys for sdk-php#420 against native Server 3.13.0.

Observed. In the PHP worker, WorkflowContext::signals() reads every signal in the history, including ones the Server has received but not yet applied to the run. In the cohort, the fixture workflow completed because of a signal that the Server later rejected for the run. A queued update was failed when the run closed, though it should have been applied first.

Expected. Workflow code sees a signal only once it is applied to the run, the point at which embedded Workflow, Python and Rust deliver it in order with updates. Received-but-unapplied or rejected signals must not change workflow decisions.

Replay. This changes what workflow code observes, so the fix needs a replay-regression fixture and a compatibility rule for histories recorded under the current behavior.

Evidence. The sdk-php#420 cohort run 44324619926 passed after the fixture applied the update before the closing signal. See the harness note in the #420 description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions