Skip to content

Document comment-only edits under versioned fingerprints (workflow#1227) - #576

Merged
rmcdaniel merged 3 commits into
mainfrom
general/1227-comment-edit-fingerprints
Nov 20, 2026
Merged

rmcdaniel merged 3 commits into
mainfrom
general/1227-comment-edit-fingerprints

Conversation

@rmcdaniel

@rmcdaniel rmcdaniel commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Docs for durable-workflow/workflow#1239, which fixes durable-workflow/workflow#1227.

Adds Comment and formatting edits (#comment-only-edits) to the workflow constraints (determinism) page:

  • By default, definition fingerprints cover raw source lines. Comment, docblock and whitespace edits in workflow classes, traits, parent workflow classes and await() conditions count as definition changes for in-flight runs.
  • From 2.34, you can opt in with DW_DEFINITION_FINGERPRINT_VERSION=v2 once all workers are upgraded. New runs then record sha256-tokens: fingerprints, which those edits don't change.
  • Runs keep the version they recorded, so switching back to v1 is safe.

The section is in all seven locales, and their source-hashes.json entries are updated. check-doc-translations.js passes, and checkTranslationUpdates passes for the changed guide.

Merge timing: merge only when the workflow release that contains #1239 ships. The text says 2.34, the expected next minor version. Correct the number in all eight files if the release ships under another version.

🤖 Generated with Claude Code

From the release with durable-workflow/workflow#1239 (#1227), runs record
token fingerprints that ignore comments and whitespace, so comment-only
edits to workflow classes and await() conditions keep replay. Runs started
earlier keep raw-line fingerprints and still treat such edits as definition
changes. Adds the note to the workflow constraints page in every locale.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@rmcdaniel rmcdaniel added the agent:general Pull request opened by General agent label Nov 19, 2026
rmcdaniel and others added 2 commits November 19, 2026 14:31
Review of durable-workflow/workflow#1239 made version 2 opt-in: new runs
record raw-line fingerprints by default, and DW_DEFINITION_FINGERPRINT_VERSION=v2
switches once every worker is on 2.34 or later. Updated in all locales.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@sonarqubecloud

Copy link
Copy Markdown

@rmcdaniel
rmcdaniel merged commit 85db0b8 into main Nov 20, 2026
11 checks passed
@rmcdaniel rmcdaniel removed the agent:general Pull request opened by General agent label Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comment-only edits to workflow classes or condition closures change replay fingerprints

1 participant