Skip to content

Admit CLI's pinned PHAR reproducibility caller - #410

Merged
rmcdaniel merged 1 commit into
mainfrom
general/cli-php-repro-admission
Nov 19, 2026
Merged

rmcdaniel merged 1 commit into
mainfrom
general/cli-php-repro-admission

Conversation

@rmcdaniel

Copy link
Copy Markdown
Member

Admits the CLI `build.yml` `reproducible-build` job's pinned PHP container profile, so CLI can drop the unbound `shivammathur/setup-php` from that job. Refs #297.

  • New runtime recipe `cli-php-repro` in `qualification/composer-container-trust.json`. It binds the already admitted PHAR-profile files (hashes unchanged from `cli-php-phar-smoke`), plus the repro setup, launcher, tree preparation, two-tree driver, their controls and the exact caller fixture, at Pin PHP for isolated reproducible PHAR builds cli#157 head `4df798b7fbbe8bffe4ead031e7bf79f1d2878861`.
  • `CLI_PHP_CI_REPRO` joins the protected runtime fields, so a job or step can't override it.
  • `tests/test_cli_php_repro_runtime.py` and fixture `tests/fixtures/cli-php-repro.yml` cover the exact caller, wrong job/workflow, borrowing by `build-phar`, each bound file and absence, setup overrides, the marker override, and verifier removal.

Validation: `qualification_policy.py validate --target cli` passes against the cli#157 head with this branch's policy. It fails against current main, which is expected. The new and existing CLI recipe tests pass. The full `python -m unittest` failures match main exactly; they come from the local container environment.

Merge order: this PR first, then cli#157, whose Central action policy preflight checks central `main`.

🤖 Generated with Claude Code

Bind the CLI build.yml reproducible-build job to its reviewed runtime
source: the admitted PHAR profile files unchanged, plus the repro setup,
launcher, tree preparation and two-tree driver, their controls and the
exact caller fixture, all at CLI PR 157 head 4df798b7. The recipe adds
CLI_PHP_CI_REPRO to the protected runtime fields. The caller still needs
the live Composer verifier before the driver's requests.

Refs #297

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@rmcdaniel rmcdaniel added the agent:general Pull request opened by General agent label Nov 19, 2026
@sonarqubecloud

Copy link
Copy Markdown

@rmcdaniel
rmcdaniel merged commit 71ba92b into main Nov 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:general Pull request opened by General agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant