Repository navigation
Admit Sample's read-only PHP launcher for its existing callers - #408
Merged
Merged
Conversation
Bind the exact sample-app f069b118 PHP CI runtime source (12 files by SHA-256 and Git mode, plus the per-Dockerfile ignore absence) for its existing callers only: ci.yml test and microservice-test on the literal PHP 8.4/8.5 matrix, and the 8.4 setup in composer-lock-audit.yml audit and playground-journeys.yml journeys. The preflight validates every sample-app workflow, so all four callers need the same launcher record. The retired writable record stays withdrawn; its launcher bytes refuse. Fixtures copy the three caller workflows, the audit request helper and the reviewed and retired launcher pairs for the focused controls. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Member
Author
|
General review of head
Marking ready for normal checks and merge. |
rmcdaniel
marked this pull request as ready for review
November 17, 2026 16:35
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Sample App PR durable-workflow/sample-app#349 (exact head
f069b118886f922e979d865d964ed5179b9bc3dc, Refs durable-workflow/sample-app#344) mounts the checkout and wrapper state read-only and makes only named data/cache/output paths writable. Its CI run fails the central preflight because the writable Sample runtime record was withdrawn in #389 and nothing replaced it. This draft adds the exact replacement record. Every existing catalog value and the policy implementation stay unchanged.Record (
qualification/composer-container-trust.json)sample-app-php-ci:ci.ymljobstestandmicroservice-test, literal matrixphp: ['8.4', '8.5'], matrix setup command only.sample-app-php84-ci:composer-lock-audit.ymlauditandplayground-journeys.ymljourneys, literal"8.4"setup command only.docker/php-ci/Dockerfile.dockerignoreto be absent. This is the same file set as the retired record. Only the three files Adopt the exact manual Ubuntu 24 PHP qualification workflow #349 changed have new hashes.composer_trust_required). A record forci.ymlalone would still refuse atcomposer-lock-audit.yml:audit:step-6, so the 8.4 callers are included. They are split out so a literal8.4command cannot be admitted inci.yml, and the matrix command cannot be admitted in the 8.4 callers.Controls (
SampleAppReadOnlyRuntimeContractTest, which runs in the existing CI module)Dockerfile.dockerignore.includematrix, an unguarded extra job, a conditional, ignored or env-overridden setup, a removed live verifier, and a job-level runtime env override.Validation
test_composer_trust_contract,test_composer_container_trust,test_qualification_policy,test_cli_phar_runtime,test_cli_php_reference_runtime): 206 tests OK in python:3.13-slim.scripts/qualification_policy.py validate --target sample-apppasses against the sample-app tree atf069b118and refuses799df847(Reviewed Composer runtime source differs: scripts/ci/run-php-container.sh).Stops
🤖 Generated with Claude Code