Repository navigation
feat(workout-ui): tabs with swipe for lap/chart, taller scan list, km chart markers - #30
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
duhow
July 26, 2026 10:29
View session
Contributor
|
✅ Debug APK artifact is ready for commit d0416f4 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The running-session card jumps when switching lap/graph views because the two views differ in height, the Bluetooth scan list is capped at ~6 devices despite free screen space, and the live chart gives no distance cues.
Stable lap/chart switching via tabs + swipe
MaterialButtonToggleGroupbelow the cards with a MaterialTabLayoutabove the card (portrait + landscape) — no new dependency.lapSectionandchartSectionin aFrameLayout; the inactive card is nowINVISIBLEinstead ofGONE, so the container always measures to the tallest view and the rectangle keeps a constant top/height.Bluetooth scan list uses available space
ScrollViewnow usesfillViewport;rvScanResultsswitched from fixed height (220dp / 160dp landscape) tolayout_weight="1", keeping the old height asminHeight. The list grows to fill remaining space while the Start button stays at the bottom.Kilometre markers in live chart
MainActivityrecords the chart point index each time a full km is completed (persisted across rotation like the other live-chart state).LineChartViewdraws a labelled vertical line per marker:Also updated changelog
6.txt. Note:btnViewLap/btnViewChartids changed type (MaterialButton→TabItem) consistently in both layout configurations for view binding.