Repository navigation
refactor(ui): remove redundant elements and make interface coherent - #29
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
duhow
July 26, 2026 10:05
View session
Contributor
|
✅ Debug APK artifact is ready for commit 3509839 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main screen accumulated incoherent UI leftovers — dead views, unicode-glyph "icons" in button labels, a view switcher that never indicated the active view, and metric cards that ignored dark mode. This cleans up the interface into a coherent fitness-recording UI (net −64 lines), following the Ponytail agent rules.
Dead UI removed
recordingIndicator("● REC"): only ever set toGONE, never shown — deleted from both portrait/landscape layouts andSessionStateMachine.btnWorkoutPause: present in both layouts but never referenced from any Kotlin code — deleted.Real icons instead of text glyphs
▶ Start,◼ Stop,◀ Back,⏸ Pauseglyph hacks from strings in all locales (en/es/ca).ic_playvector and used it on the Start button, replacing the incongruous clock icon (ic_time).recording,paused,workout_pause,workout_resume,start_session,stop_session) from all locales.Lap/Chart switcher indicates active view
viewToggleRowto aMaterialButtonToggleGroup(single-selection, selection-required). Previously the "Lap" button always looked selected regardless of the visible view.setWorkoutView(), which also syncs the checked button:Dark-mode coherence
values-night/colors.xmlwith dark-tinted metric card backgrounds and lighter accents; cards previously kept hard-coded light pastel backgrounds under the DayNight theme.tools/lint.pylanguage-parity check to skip non-localevalues-*qualifiers (e.g.values-night,values-v31).Also updated changelog
6.txt. Note:assembleDebugcould not run in the sandbox (Google Maven blocked at AGP resolution — pre-existing, unrelated); please rely on CI for the build check.tools/lint.pypasses 4/4.