Skip to content

Fix #573: Emit success event from accrue() - #607

Open
badmusdare4 wants to merge 1 commit into
drydocs:mainfrom
badmusdare4:fix-blendadapter-accrue
Open

Fix #573: Emit success event from accrue()#607
badmusdare4 wants to merge 1 commit into
drydocs:mainfrom
badmusdare4:fix-blendadapter-accrue

Conversation

@badmusdare4

Copy link
Copy Markdown

��## Summary

  • Emit a success event from BlendAdapter::accrue() carrying the previous and new cached otal_assets() values. This makes �ccrue() genuinely observable for keepers.
  • Added a unit test to verify the event is emitted with expected payload.

Test plan

  • cargo test passes locally
  • Asserted event fires with expected values

Closes #573

@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

@badmusdare4 is attempting to deploy a commit to the Collins' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Aug 26, 2026

Copy link
Copy Markdown

@badmusdare4 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@collinsezedike collinsezedike left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@badmusdare4 the fix itself is correct, verified prev is read before the storage write and the test's rate math checks out. A few things need fixing before this can merge:

  • PR Title/Commit Messages fail: the title (Fix #573: Emit success event from accrue()) doesn't follow CONTRIBUTING.md's commit convention (type(scope): subject), it becomes the squash commit message.
  • Soroban Contract Tests fails on cargo fmt --all -- --check, two lines in the new test exceed the line width. Run cargo fmt --all before pushing.
  • The PR body has corrupted control characters mid-word (otal_assets(), and a stray character before ccrue()), looks like a paste-encoding issue. Please re-paste it cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Emit a success event from accrue()

2 participants