Repository navigation
Fix public contrast, tap targets, skip link, and 390px header - #274
Conversation
Add a shared public-a11y stylesheet so WCAG AA hero contrast, 24px tap targets, a skip-to-content link, and a nowrap 390px header land without editing the soundtrack/journal hero rules in PR 263. Co-authored-by: Patrick <[email protected]>
Keep skip-link and 390px header rules. Drop the 95% navy overlay to #081832cc behind the text column, fading to #081832b3 on the photo side. Co-authored-by: Patrick <[email protected]>
Co-authored-by: Patrick <[email protected]>
Co-authored-by: Patrick <[email protected]>
…ntrast-4d80 Co-authored-by: Patrick <[email protected]>
Resolve web/beta.html by taking main's head tags and preload, and keep the public-a11y.css?v=2 link from this PR. Co-authored-by: Patrick <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c18bfe3ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| section.hero { | ||
| background: linear-gradient(90deg, #081832cc 0%, #081832cc 58%, #081832b3 78%, #08183280 100%), url("/assets/beta/grand-touring-home.webp") center 55% / cover; |
There was a problem hiding this comment.
Limit the overlay rule to public-page heroes
Because beta.html now imports this stylesheet and the / front cover is also a <section class="hero section-shell">, this selector unintentionally applies the forest background to the entire home-page hero. That changes the existing plain cover design and eagerly downloads the 322 KB full-size image, even though the homepage previously used responsive, lazy-loaded variants only in its later scenic section. Scope these background rules to the public-page hero variant while retaining the shared header and tap-target fixes on /.
Useful? React with 👍 / 👎.
Lighthouse on journeydeck.me (Oct 12) reported color contrast, tap target, skip-link, and header-wrap issues on the public site.
This PR adds
web/public-a11y.cssand a skip-to-content link on/,/privacy,/support,/terms,/apple-music-soundtrack,/private-driving-journal, and the 404 page. After #263 and #275 landed onmain, this branch mergedmainagain so the soundtrack/journal heroes keep thehas-photosrcset, the current App Store copy, and this overlay still wins viasection.hero.has-photo::before.Fixes
#081832f8/f4/e8, about 95% solid) hid the forest photo. Review follow-up lightens it to#081832ccbehind the text column, fading to#081832b3then#08183280on the photo side. On viewports 620px and below the text is full width, so the overlay stays#081832ccto#081832c6. Header nowrap and skip-link rules are unchanged.Skip to contentpoints atmain#main.flex-wrap: nowrapplus tighter padding so Menu and Get the app stay on one row.CSP is unchanged. No em or en dashes were added.
WCAG AA contrast (rechecked after the lighter overlay)
Gold
#d4b15a, ivory#f6f0e2, and lede#e4e3dfon navy#081832, plus worst-case#081832ccover white:#081832ccover white#081832b3(70%) over white would drop gold to 3.23:1, so that stop is only on the photo side, not under the text.Tests
server/tests/public-a11y.test.tsasserts the stylesheet (?v=2), skip link,#main, the#081832cc/#081832b3overlay, and CSP on each public page.Do not merge or deploy from this PR.
Hero screenshots after the lighter overlay (1280x800 and 390x844)
Captured after merging #263's
has-photomarkup so the photo and overlay are the production stack. The journal phone frame was reshot after #275 so it shows the current lede (no dash line) and Download on the App Store, not Start free on iPhone.Header, skip link, and earlier shots