Repository navigation
Add HSTS for HTTPS production responses only - #272
Merged
Merged
Conversation
Add Strict-Transport-Security: max-age=31536000 on hosted web responses that arrive over HTTPS. Omit includeSubDomains and preload. Desktop and HTTP remain unchanged, and the Content-Security-Policy is not modified. Co-authored-by: Patrick <[email protected]>
drumpat01
marked this pull request as ready for review
October 12, 2026 17:30
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lighthouse on journeydeck.me (Oct 12) reported a missing Strict-Transport-Security header.
This PR sends
Strict-Transport-Security: max-age=31536000only when all of these are true:DRIVEOS_MODE=web(hosted production front door)DRIVEOS_NODE_PUBLIC_ORIGINishttps:req.protocolor the firstX-Forwarded-Protovalue)The header does not include
includeSubDomainsorpreload. Desktop, HTTP, and non-https public origins stay unchanged. The Content-Security-Policy string is not modified.Browser note
Browsers that see this header will remember HTTPS-only for journeydeck.me for one year (31,536,000 seconds). A mistaken deploy is sticky: HTTP visitors can be blocked from the site until the max-age expires or they clear site data. That is why this PR keeps HSTS off HTTP, off desktop, and off
includeSubDomains/preload.Tests
server/tests/hsts.test.tscovers HTTPS production (header present and exact), HTTP production (absent), desktop HTTPS (absent), and web mode with anhttp:public origin (absent). CSPdefault-src 'self'remains on the HTTPS production response.JourneyDeck CI / validate is green. No visual change, so no screenshots. Do not merge or deploy from this PR.