Repository navigation
Reduce home, favicon, medallion, and soundtrack image weight - #271
Conversation
Give the home page LCP a 400w/660w WebP srcset with preload and fetchpriority, and serve the scenic photo at 800w/1600w the same way as the open soundtrack/journal hero PR. Shrink picker medallions to 128px, add a 32px favicon beside the existing 192px icons, and convert the soundtrack page JPEG to WebP. Co-authored-by: Patrick <[email protected]>
Keep main hero srcset and JourneyDeck 4.0 copy, and keep the soundtrack WebP weight savings. Co-authored-by: Patrick <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Keep travel-journal routes, tests, verify-live pages, and the soundtrack footer link alongside the landed journal and tracker pages. Co-authored-by: Patrick <[email protected]>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f03deef3b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <meta name="twitter:site" content="@JourneyDeck"> | ||
| <meta name="twitter:image" content="https://journeydeck.me/assets/beta/share-card.png?v=1"> | ||
| <meta name="twitter:image:alt" content="JourneyDeck: every route, every song, every memory. A phone showing a Summer Vacation Memory."> | ||
| <link rel="icon" type="image/png" sizes="32x32" href="/assets/favicon-32.png?v=app-logo-1"> |
There was a problem hiding this comment.
Add the small favicon to the road-trip page
When a user visits the public /road-trip-tracker-app landing page, web/road-trip-tracker-app.html:23 still offers only the 53,692-byte 192×192 favicon, so it misses the roughly 51 KB saving applied here to every other public marketing page. Add the same 32×32 favicon link to that page and include it in the public-image coverage.
Useful? React with 👍 / 👎.
Keep driving-history routes, tests, verify-live rows, sitemap, and soundtrack footer on top of travel-journal content from #273, including the #271 image-weight assets now on that branch. Co-authored-by: Patrick <[email protected]>
Lighthouse on journeydeck.me (Oct 12) flagged image weight on the public site. This PR is based on latest
mainand stays off the soundtrack/journal hero markup in open PR #263. The 800w/1600w scenic files match that PR's binaries so the two can merge cleanly.The home page LCP is the 660px Today screenshot, not the 1536px forest photo. Upscaling it to 800w/1600w would add weight, so the hero uses an honest 400w/660w WebP srcset with preload,
imagesrcset,imagesizes,fetchpriority="high", and?v=1. The full-bleed scenic photo uses the same 800w/1600w pattern as #263, lazy-loaded below the fold. Hosting, DNS, analytics, and CSP are untouched.File sizes (measured on disk)
01-today.webpgrand-touring-home.webpsoundtrack.jpgfavicon.pngA 390px phone now requests 31.1 KB for the home LCP instead of 91.9 KB, 91.3 KB for the scenic photo instead of 314.6 KB, 25.1 KB for the soundtrack screenshot instead of 122.1 KB, and about 62 KB for ten picker coins instead of about 596 KB.
Tests
server/tests/public-images.test.tsasserts:fetchpriority="high"public, max-age=31536000, immutablesoundtrack.webp?v=1, not the JPEGJourneyDeck CI / validate is green. Do not merge or deploy from this PR.
Review follow-up: loaded medallion screenshots
The first desktop medallion shots were taken while the viewer still said Preparing Soundtrack. These 1280x800 frames were recaptured after
#medallion-statusreadSoundtrack 100 · Grand Touringand.medallion-stagehadis-ready, so the large coin sharpness is visible.Other screenshots (1280x800 and 390x844)
Home hero before/after. Visual layout is unchanged; the phone now loads the 31.1 KB 400w source.
Scenic break before/after (800w/1600w srcset, same photo).
Soundtrack remaining JPEG converted to WebP (122.1 KB to 25.1 KB).