Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.14 reports invalid string escapes and a return inside finally when the Sublime plugin loads. Use raw strings and return after restoring the editor setting. Also fix MergeException message access so rollback restores the original buffer instead of silently leaving a partial edit.
Add 11 standard-library tests covering source compilation, completion escaping, patch headers, buffer edits and exception recovery. Keep the test harness compatible with Python 3.3 and preserve real imported dependencies while isolating the Sublime API.
The regular CI suite tests all nine combinations of Python 3.3, 3.8 and 3.14 with Linux, macOS Intel and Windows. Each job verifies its actual interpreter before compiling the plugin and running the same tests. Legacy Python 3.3 is built from the official 3.3.7 sources on Linux and uses the official 3.3.5 binaries on macOS/Windows; the macOS framework is extracted into the temporary runner directory without system installation.
Add four integration tests inside official stable Sublime Text 4200 in evaluation mode, without a license or repository secrets. Run Python hosts 3.3 and 3.8 on Linux, macOS Intel and Windows. Reuse pinned UnitTesting 1.9.2 and retain editor logs as CI artifacts. Tests cover loading, formatting and idempotence, real PHP/SQLite completion snippets, and rollback on a real buffer.
The editor tests also exposed a completion regression: modern PHP syntax uses source.php.embedded.html. Use Sublime match_selector instead of exact historical scope names.
Validation:
Refs #102. Plane: PHPFMT-2.