Upgrade bootstrap-vue-next to 1.0.1 in client-v3 - #1326
Merged
Conversation
Jumps straight to the first stable 1.x release rather than the 0.46.x dependabot bump, since resolver config, plugin registration, and peer deps are all unchanged in this range. The one real breaking change is BFormCheckbox's unchecked-value default flipping from false to undefined (landed in 0.46.0) - restored the old behavior explicitly on all 14 affected checkboxes across 7 files. Co-Authored-By: Claude Sonnet 5 <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
bootstrap-vue-nextfrom^0.45.7(resolved0.45.10) to^1.0.1inclient-v3— the library's first stable major release. Supersedes the dependabot 0.46.4 bump (Bump bootstrap-vue-next from 0.45.10 to 0.46.4 in /client-v3 #1324, closed) since it made more sense to jump straight to 1.x while the gap was still small.BFormCheckbox'sunchecked-valuedefault flipped fromfalsetoundefinedin0.46.0. Added explicit:unchecked-value="false"to all 14 affected plain checkboxes across 7 files (ConfigSettings.vue,ConfigLogs.vue,ConfigUsers.vue,ConfigActs.vue×2,UserSettingsConfig.vue×5,StageDirectionStyles.vue×3,ServerSelector.vue) to preserve prior behavior.Everything else in the 0.45.10→1.0.1 changelog (resolver config, plugin registration, peer deps,
BFormRatingprop/slot renames, orchestrator composable internals) either doesn't apply to how this app uses BVN, or was confirmed unchanged (e.g.BFormGroupstill emits the.b-form-groupclass thatdark.scssdepends on — verified directly in the compiled output).Test plan
npm run typecheck— clean (the 30-fileBModaltyped-ref surface is unaffected)npm run ci-lint— cleannpm run test:run— 39/39 Vitest tests passnpm run buildandBUILD_TARGET=electron npm run build— both succeed (confirms the package's move to ESM-only doesn't break the Vite build)npm run test:e2e— full suite, 221/221 passing, including toggle-behavior specs that directly exercise the checkbox fix🤖 Generated with Claude Code