Skip to content

Resolve conditional constant declarations in expanded analysis - #69

Merged
TristanKruse merged 1 commit into
mainfrom
fix/constant-writes-64
Oct 26, 2026
Merged

TristanKruse merged 1 commit into
mainfrom
fix/constant-writes-64

Conversation

@TristanKruse

@TristanKruse TristanKruse commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fixes #64.

  • Index lexical, qualified, and root-qualified ||= constant declarations in expanded mode using the existing declaration/evidence pipeline. This records possible definition ownership, not runtime execution or value folding.
  • Preserve the import-only default, ambiguity handling, lexical qualification, parallel-edge evidence merging, and explicit cache refresh.
  • Review and document other writes deliberately: update-only compound and unsupported multiple-assignment forms are not inferred as new declaration owners.
  • Add focused public-rule regressions plus an installed-gem smoke script invoked by CI, including permitted rules, target evidence, RHS dependencies, layers/slices/reports, and non-execution guarantees.

Validation

  • Before fix: all 8 initial reproducer/regression examples failed.
  • After fix: 602 examples, 0 failures (8 Windows symlink skips); 262 files lint-clean.
  • Documentation and installed-API smoke pass. All six pinned real-world canary modes retain their reviewed graph fingerprints.
  • Independent sibling of Fail closed on malformed Ruby with structured parse diagnostics #68, based on main. No merge, version bump, or publication.

Combined validation

Locally combined #68, #69, and #70 on an unpushed verification branch without conflicts. Passed: 614 examples with zero failures (8 Windows native-symlink skips); runtime-library-only coverage 98.48% line / 91.51% branch at unchanged 98% / 90% thresholds; 267 files lint-clean; 179 documentation pages validated; both public/installed-API smoke scripts; fresh scan of 1,269 advisories with zero findings and successful health detection; all six pinned Rack/Rake/RSpec canary modes with reviewed fingerprints unchanged. All GitHub checks on each PR are green. No PR was merged and no release/version bump was performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Constant analysis: index ||= declarations and qualified constant writes

1 participant