fix(useCombobox): preserve IME composition - #1699
Open
naveedsajjdawan wants to merge 1 commit into
Open
naveedsajjdawan wants to merge 1 commit into
naveedsajjdawan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
InputChangedispatches while the browser reports an active IME composition.onChange/onInputhandlers running during composition.Why
With a controlled
inputValue, dispatching every intermediate IME input event triggers Downshift state callbacks and rerenders the input. That can terminate the browser's composition session before users finish entering Japanese, Chinese, Korean, or other composition-based text.Deferring Downshift's internal update until the committed input event preserves the native composition session without changing normal input behavior.
Verification
npx jest src/hooks/useCombobox/__tests__/getInputProps.test.js --runInBand— 153 tests passednpx tsc --noEmit -p ./tsconfig.json— passedFixes #1452