Fix ControlPaint.Dark interpolation for SystemColors.Control - #14829
Merged
Shyam-Gupta merged 1 commit intoJul 31, 2026
Merged
Conversation
…special-case path. Problem ControlPaint_Dark_InvokeColorFloat_ReturnsExpected was failing for SystemColors.Control with negative darkening percentages because the interpolation logic performed an intermediate byte cast, producing incorrect channel values. Solution Perform the interpolation in int and cast to byte only once at the end of the calculation. Testing • System.Windows.Forms.Tests.ControlPaint_Dark_InvokeColorFloat_ReturnsExpected
Member
Author
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
LeafShi1
approved these changes
Jul 31, 2026
Shyam-Gupta
merged commit Jul 31, 2026
e6ac4d6
into
darc-main-df5ce6ac-c4fd-4820-8362-e0f3c36b45c4
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the test failures in codeflow PR #14825
Fix ControlPaint.Dark(Color, float) for the SystemColors.Control special-case path.
Problem
ControlPaint_Dark_InvokeColorFloat_ReturnsExpected was failing for SystemColors.Control with negative darkening percentages because the interpolation logic performed an intermediate byte cast, producing incorrect channel values.
Solution
Perform the interpolation in int and cast to byte only once at the end of the calculation.
Testing
• System.Windows.Forms.Tests.ControlPaint_Dark_InvokeColorFloat_ReturnsExpected
Microsoft Reviewers: Open in CodeFlow