Temp fix for Google Translate - Bad Request (400) - #767
Open
burukan wants to merge 1 commit into
Open
Conversation
…ll a query limit (5k) and will require multiple presses to "Start + Apply" if some text to be translated is too long. In next revision may do Take(1) till max(10, payload limit) for enumerator and let it do its thing. However another bigger issue remains: a single source can be bigger than 5k limit and splitting it up may degrade the nmt translation context causing worse translation on Google's end. This needs some research on proper splitting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save the day / temporary fix for Google Bad Request (400). This will pull text till a query limit (5k) and will require multiple presses to "Start + Apply" if some text to be translated is too long. In next revision may do Take(1) till max(10, payload limit) for enumerator and let it do its thing. However another bigger issue remains: a single source can be bigger than 5k limit and splitting it up may degrade the nmt translation context causing worse translation on Google's end. This needs some research on proper splitting.
Tested and works on my projects (albeit with multiple Starts/Applies) with longer source text. Will come back to this soon to improve the process.