Admit a partial answer once the memory pass has run by donislawdev · Pull Request #9 · donislawdev/BetterWindowsServices

donislawdev · 2026-09-23T15:32:05Z

What was wrong

A window without administrator rights answered status:running memory:>100MB with "Nothing in this list matches what you asked for" and said nothing else. On the machine this was found on, Windows had refused the memory of 104 service processes (memory:? counts them), so "no service holds more than 100 MB" read as the answer while most running services were never judged.

The sentence that admits a partial answer was held back for every query needing a second phase family (memory or signatures), including after that family had been read. The query engine counts a refused field and a field nobody read as one number, and the hold-back existed so that "nobody looked" would not be reported as a refusal. Once the pass has run, what is left unread is a refusal, and the hold-back had no reason to stay.

A shown Memory column sets the same need, so it silenced the sentence for questions about any other field too.

What changed

Sentences.Admissions holds the sentence back only while a family the query needs has not been read: (needs & ~have) == ExtraRead.None instead of needs == ExtraRead.None.
The command line already printed this warning on any count, so both interfaces now agree on the same answer.
CHANGELOG.md: one entry under Fixed.

Tests

Four new tests in AdmissionTests:

a refusal the memory pass brought back is admitted (fails on the previous code),
a shown memory column does not silence a refusal about another field (fails on the previous code),
a pass that read every process admits nothing,
while one needed family is still unread the refusal sentence stays back - and the test proves memory was read, so it sits on the boundary it names.

Checked on the live window without administrator rights: the same query now says "104 entries were judged on a field that could not be read, so this list may be missing entries, or holding ones that do not belong."

Four window tests read the real process token and fail on any session without administrator rights. They fail identically on the code before this change.

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Partial-results notices now accurately report entries that could not be evaluated due to unreadable memory, including when the Memory column is displayed alongside a query for another field.
- Notices appear after required data has been read, while remaining suppressed if necessary data is still unavailable.
Documentation
- Added a changelog entry describing the unreadable-memory notice.

A window without administrator rights answered "status:running memory:>100MB" with an empty list and nothing else, while Windows had refused the memory of most service processes. The sentence that says an answer rests on fields that could not be read was held back for every query needing a second phase family, even after that family had been read - when what is left unread is a refusal. The sentence is now held back only while a family the query needs is still unread. A shown Memory column, which asks for the same family, no longer silences it for questions about other fields either. The command line already said this on any count, so both interfaces now agree on the same answer. Four tests pin the change: the refusal after the pass, a pass that read everything, a family still unread, and the shown column. The first and the last fail on the previous code. Co-Authored-By: Claude Opus 5.5 <[email protected]>

coderabbitai · 2026-09-23T15:32:19Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 7dc244ff-b6d8-4206-8a17-ef2b20fe5ab0

📥 Commits

Reviewing files that changed from the base of the PR and between eba59a3 and 2e75484.

📒 Files selected for processing (3)

CHANGELOG.md
src/Bws.Gui/ViewModels/Sentences.cs
tests/Bws.Gui.Tests/AdmissionTests.cs

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (5)

GitHub Check: Analyse csharp
GitHub Check: Analyse actions
GitHub Check: build and the tests that do not need this machine
GitHub Check: Dependency review
GitHub Check: Semgrep

🧰 Additional context used

📓 Path-based instructions (10)

Applies to text shown to the user (labels, buttons, tooltips, placeholders, dialogs, errors, status messages, empty states, translations).