Repository navigation
Fix SVG viewport and path geometry - #143
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #128, #93
Reassessment of the current patch at 358c38d:
Follow-up source work is still needed: repair the normalized attribute key and standard Y alignment tests, and remove the unsupported rendering claim/hunk rather than treating it as proven. Any wider #93 root/nested viewport repair requires its own complete caller-level assessment. The existing source branch has not been revised in this reassessment because source pushes would trigger the configured CI, which this task is not authorized to execute.
Validation limits: no PHP CLI, tests, lint, build, SVG/PDF/font rendering, browser validation, installation, or CI execution was performed in this reassessment. Existing green PHP 7.1-8.4 checks and CodeFactor are not dedicated geometry regression proof. Prior whitespace-check evidence applies only to the unchanged source patch.