You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
phpstan reports the same warnings with both 8 and 9. They should probably be fixed regardless. The signatures are the same, so I imagine they are compatible.
I'm hesitant to fix these, though, because you're still supporting PHP 7.1, and maintaining compatibility with that is awkward. If yo ever release a new version, I'd recommend rector and updating to only supported versions of php.
Very low priority, I just noticed the new version of that library.
89 Method Svg\Style::fromAttributes() should return Svg\Style but return statement is missing.
🪪 return.missing
91 Method Svg\Style::fromAttributes() should return Svg\Style but return statement is missing.
🪪 return.missing
changed the title [-]phpstan reports the same warnings with both 8 and 9. They should probably be fixed regardless. The signatures are the same, so I imagine they are compatible.[/-][+]Address issues reported by phpstan[/+]on Aug 21, 2025
Activity
[-]phpstan reports the same warnings with both 8 and 9. They should probably be fixed regardless. The signatures are the same, so I imagine they are compatible.[/-][+]Address issues reported by phpstan[/+]williamdes commentedon Sep 18, 2025
Curiously
_convert_gif_bmp_to_pngdoes not exist for us, but some users seems to have it: https://github.com/search?q=%22_convert_gif_bmp_to_png%22&type=codewilliamdes commentedon Sep 18, 2025
Aha, it was renamed from
_convert_gif_bmp_to_pngto_convert_to_pngin dompdf/dompdf@beb8984williamdes commentedon Sep 18, 2025
@bsweeney you should look into this as it seems you changed the nearby code in the recent years
bsweeney commentedon Sep 23, 2025
I'll review differences between the Dompdf and SvgLib versions for the next release. Thanks for your efforts.