System/MarNameRefGen_BossEnemy: construct Boss Pakkun variants - #199
Closed
KakarottoCake wants to merge 1 commit into
Closed
KakarottoCake wants to merge 1 commit into
KakarottoCake wants to merge 1 commit into
Conversation
Report for GMSJ01 (7846008 - defd5a3)📈 2 improvements in unmatched items
Report for GMSP01 (7846008 - defd5a3)📈 2 improvements in unmatched items
|
Contributor
Author
|
Closing this PR because its scope is too narrow. Reworking the full Mario/System directory in a replacement PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores four Boss Pakkun factory cases in
TMarNameRefGen::getNameRef_BossEnemy: BossPakkun, KBossPakkun, and their managers.MarNameRefGen_BossEnemyfuzzy match: 25.19% -> 30.63%. No new exact functions; the unit still has missing cases.Checked with native Windows bare Ninja, clang-format, review-lint, and changed-symbol-order against the baseline object (0 new symbol errors).