it: declare Article attribute unions and typed callers - #3600
Merged
itsgrimetime merged 12 commits intoOct 4, 2026
Merged
Conversation
ribbanya
reviewed
Oct 1, 2026
ribbanya
reviewed
Oct 1, 2026
ribbanya
reviewed
Oct 2, 2026
ribbanya
left a comment
Collaborator
There was a problem hiding this comment.
Are any of the dat-cli changes necessary still?
Collaborator
Author
yeah i'm pretty sure they're still needed for the samus fix (but not for the article cleanup). the rust changes are what brings the fighter kind from the loader's name table into the walk & letting without those changes it reports an ambiguous union at samus's slot 4 |
ribbanya
requested changes
Oct 2, 2026
ribbanya
left a comment
Collaborator
There was a problem hiding this comment.
If it is necessary, please split the PRs. A src-only changeset would be much easier to review.
ribbanya
requested changes
Oct 2, 2026
ribbanya
requested changes
Oct 2, 2026
ribbanya
reviewed
Oct 3, 2026
ribbanya
reviewed
Oct 3, 2026
ribbanya
reviewed
Oct 3, 2026
ribbanya
reviewed
Oct 3, 2026
ribbanya
reviewed
Oct 3, 2026
ribbanya
previously approved these changes
Oct 3, 2026
itsgrimetime
force-pushed
the
codex/dat-root-bindings-samus
branch
from
October 3, 2026 20:50
ed1a2c9 to
f44f876
Compare
ribbanya
previously approved these changes
Oct 3, 2026
itsgrimetime
enabled auto-merge (squash)
October 3, 2026 23:30
itsgrimetime
force-pushed
the
codex/dat-root-bindings-samus
branch
from
October 4, 2026 06:12
2ed0828 to
fb35f2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.