Skip to content

Match fixed menu camera initialization and update - #143

Open
loserkidsblink wants to merge 2 commits into
doldecomp:mainfrom
loserkidsblink:decomp/menu-fixed-controller
Open

loserkidsblink wants to merge 2 commits into
doldecomp:mainfrom
loserkidsblink:decomp/menu-fixed-controller

Conversation

@loserkidsblink

@loserkidsblink loserkidsblink commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Match cmMenuFixedController::init() and update(float) for RSBE01_02.
  • Identify the previously unnamed update function at 0x800A69AC and update its symbol map entry.
  • Cache camera pointers, update packed transform flags as 16-bit masks, and preserve the original rotation initialization sequence.

Verification

  • python3 configure.py and ninja --quiet all_source build/RSBE01_02/ok build/RSBE01_02/report.json pass.
  • Matched code in cm_controller_menu_fixed rises from 128 to 440 bytes (+312); all 4 functions reach 100%.
  • The unit's remaining data differences are in RTTI and related metadata.

Related work

@decomp-dev

decomp-dev Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Report for RSBE01_02 (f168bd9 - b70b65e)

📈 Matched code: 1.20% (+0.00%, +312 bytes)
📈 Matched data: 14.59% (+0.00%, +8 bytes)

✅ 3 new matches
Unit Item Bytes Before After
main/sora/cm/cm_controller_menu_fixed cmMenuFixedController::update(float) +204 0.00% 100.00%
main/sora/cm/cm_controller_menu_fixed cmMenuFixedController::init() +83 23.22% 100.00%
main/sora/cm/cm_controller_menu_fixed .sdata +8 0.00% 100.00%
📈 1 improvement in an unmatched item
Unit Item Bytes Before After
main/sora/cm/cm_controller_menu_fixed .data +46 0.00% 83.46%

@loserkidsblink loserkidsblink changed the title Match fixed menu camera initialization Match fixed menu camera initialization and update Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant