Match enemy portrait lookup and link value accessor - #139
Open
loserkidsblink wants to merge 1 commit into
Open
loserkidsblink wants to merge 1 commit into
loserkidsblink wants to merge 1 commit into
Conversation
Report for RSBE01_02 (f168bd9 - 2e20389)📈 Matched code: 1.20% (+0.00%, +132 bytes) ✅ 1 new match
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete the remaining mismatch in
emExternalValueAccesser::getFaceTexPtrand linkem_external_value_accesser.cppas matching.Use explicit branches for the missing-weapon fallback and assign the weapon's portrait selector before calling
Enemy::getFaceTexPtr. This removes the extra register copy and reproduces the original instruction sequence.This adds one newly matched function (132 bytes) and enables the existing 11-function unit (916 bytes) to be linked from C++. The other functions were already matching.
Validation on RSBE01_02:
ninja: all 127 output files pass the original SHA-1 checks.git diff --check: passes.